Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added dependabot #1144

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Conversation

disha1202
Copy link

@disha1202 disha1202 commented Dec 6, 2023

What kind of change does this PR introduce?
feature

Issue Number:

Fixes #1104

Did you add tests for your changes?

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?
No

Other information

Added Dependabot for weekly automated dependency updates
Have you read the contributing guide?
Yes

@disha1202 disha1202 requested a review from palisadoes as a code owner December 6, 2023 19:25
Copy link

github-actions bot commented Dec 6, 2023

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

@palisadoes
Copy link
Contributor

Please take a look at this for standardization

@palisadoes palisadoes requested a review from EshaanAgg December 6, 2023 19:44
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c6d8f4) 94.49% compared to head (3828687) 94.49%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1144   +/-   ##
========================================
  Coverage    94.49%   94.49%           
========================================
  Files          138      138           
  Lines         3286     3286           
  Branches       912      912           
========================================
  Hits          3105     3105           
  Misses         174      174           
  Partials         7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@EshaanAgg EshaanAgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@disha1202 Please add the comments and the same prefix for dependabot PRs as done in the linked file by Peter. Please re-request a review after you do so.

@disha1202 disha1202 requested a review from EshaanAgg December 7, 2023 10:03
@disha1202
Copy link
Author

Hi @EshaanAgg

I have updated the PR.

Please take a look.

Copy link
Contributor

@EshaanAgg EshaanAgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noman2002 noman2002 merged commit b59bdf0 into PalisadoesFoundation:develop Dec 7, 2023
6 of 8 checks passed
palisadoes added a commit that referenced this pull request Dec 7, 2023
@palisadoes
Copy link
Contributor

palisadoes commented Dec 7, 2023

  1. I have to revert this. The file is in the wrong directory and is causing other merges to fail.
  2. @disha1202 refer to this and submit a new PR based on the original issue

palisadoes added a commit that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants