Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADMIN - Remove Legacy Plugin Code #3793

Open
meetulr opened this issue Mar 4, 2025 · 12 comments
Open

ADMIN - Remove Legacy Plugin Code #3793

meetulr opened this issue Mar 4, 2025 · 12 comments
Assignees
Labels
cleanup Remove non-functional or unnecessary code GSoC Priority

Comments

@meetulr
Copy link
Contributor

meetulr commented Mar 4, 2025

Describe the issue

The current plugin system does not meet our requirements in terms of functionality and scalability. We plan to implement an intuitive, robust and scalable plugin architecture with this GSoC project.

Describe the solution

Remove any existing code related to the plugin functionality.

Additional Context

Companion issue: PalisadoesFoundation/talawa-api#3337

@hustlernik
Copy link
Contributor

@meetulr Please assign.

@meetulr meetulr added the cleanup Remove non-functional or unnecessary code label Mar 4, 2025
@meetulr
Copy link
Contributor Author

meetulr commented Mar 4, 2025

@hustlernik, you’re already assigned to 3 issues. Our policy allows a maximum of 2 issues per contributor.

@bandhan-majumder
Copy link
Contributor

bandhan-majumder commented Mar 4, 2025

@meetulr please assign. Please unassign me this issue to meet 2 issue criteria

@meetulr
Copy link
Contributor Author

meetulr commented Mar 4, 2025

If you're no longer working on an issue, you can mention it there and unassign yourself.

@meetulr
Copy link
Contributor Author

meetulr commented Mar 4, 2025

@bandhan-majumder Keep in mind the PR for admin should be merged first or it may cause things to break.

@bandhan-majumder
Copy link
Contributor

bandhan-majumder commented Mar 4, 2025

@meetulr

Sure. And after that I may have to wait for talawa repo to remove legacy code before removing it in api too I guess.

@meetulr
Copy link
Contributor Author

meetulr commented Mar 4, 2025

You can raise the prs simultaneously. It's just that the frontend ones should be merged first.

@bandhan-majumder
Copy link
Contributor

@meetulr there are user level authorization of creating/blocking plugins. Should I remove them too from schema?

example:

Image

@meetulr
Copy link
Contributor Author

meetulr commented Mar 4, 2025

Yes, everything relevant.

@bandhan-majumder
Copy link
Contributor

@meetulr @palisadoes

as we do not have full api support, I have removed the code with keeping the merged PR #3804 in mind (related files).
I have checked both with change and without change, the state and the errors are same. And that made me confident that the changes will not break any existing code/feature. I have tried it multiple times. LMK if any changes are still required.

@bandhan-majumder
Copy link
Contributor

@palisadoes @meetulr

I missed a return filed to remove in develop branch. Added in the recently mentioned PR.

@Cioppolo14 Cioppolo14 reopened this Mar 9, 2025
@Cioppolo14
Copy link
Contributor

Reopening this issue until this new PR is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Remove non-functional or unnecessary code GSoC Priority
Projects
None yet
Development

No branches or pull requests

5 participants