Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMongo: Replace Base64 Storage with MinIO Client in OrganizationModal.tsx #3727

Open
NishantSinghhhhh opened this issue Feb 22, 2025 · 5 comments

Comments

@NishantSinghhhhh
Copy link
Contributor

NishantSinghhhhh commented Feb 22, 2025

Problem
OrganizationModal.tsx currently stores images using Base64 encoding, leading to increased memory usage and slower performance.

Solution
Replace Base64 encoding with MinIO client for direct file uploads and store only file URLs.

Alternatives Considered

  • Keeping Base64 (causes larger payloads).
  • Using external cloud storage (MinIO provides a self-hosted alternative).

Approach

  1. Remove Base64 encoding logic.
  2. Implement MinIO upload for organization images.
  3. Store and retrieve file URLs efficiently.

Additional Context
This update will optimize performance, reduce bandwidth usage, and improve data handling.


NOTE

  1. We recently discovered a flaw in the code base where there are some XSS and CORS vulnerabilities. This occurs when the API and Admin servers run on different machines.

  2. You will notice this if you configure your Admin app on your local machine to use the API running on https://test.talawa.io/graphql.

  3. The errors in your browser will look like this:

    Image

  4. As part of this issue you will need to ensure that the browser only interacts with the API through the Admin server and never with the API directly.

@palisadoes palisadoes changed the title Feature Request : Replace Base64 Storage with MinIO Client in OrganizationModal.tsx NoMongo: Replace Base64 Storage with MinIO Client in OrganizationModal.tsx Feb 24, 2025
@Aaradhya-07
Copy link

please assign @palisadoes

@palisadoes
Copy link
Contributor

PTAL at the XSS and CORS vulnerabilities mentioned above that you will need to address as part of this.

@palisadoes
Copy link
Contributor

Unassigning. 2 weeks of inactivity

@palisadoes palisadoes added the good first issue Good for newcomers label Mar 9, 2025
@MayankJha014
Copy link
Contributor

Assign this to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

5 participants