Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMongo: Replace Base64 Storage with MinIO Client in ChatRoom.tsx #3723

Open
NishantSinghhhhh opened this issue Feb 22, 2025 · 4 comments
Open

Comments

@NishantSinghhhhh
Copy link
Contributor

NishantSinghhhhh commented Feb 22, 2025

Problem
ChatRoom.tsx currently uses Base64 encoding for storing images and media, leading to high memory consumption and slower performance.

Solution
Implement MinIO client for direct file uploads, storing only the file URLs instead of Base64 strings.

Alternatives Considered

  • Keeping Base64 (inefficient for large files).
  • Using third-party cloud storage (MinIO offers a self-hosted solution).

Approach

  1. Remove Base64 encoding logic.
  2. Integrate MinIO file upload for media messages.
  3. Store and retrieve file URLs efficiently.

Additional Context
This change will improve chat performance, reduce payload size, and optimize storage usage.


NOTE

  1. We recently discovered a flaw in the code base where there are some XSS and CORS vulnerabilities. This occurs when the API and Admin servers run on different machines.

  2. You will notice this if you configure your Admin app on your local machine to use the API running on https://test.talawa.io/graphql.

  3. The errors in your browser will look like this:

    Image

  4. As part of this issue you will need to ensure that the browser only interacts with the API through the Admin server and never with the API directly.

@palisadoes palisadoes changed the title Feature Request: Replace Base64 Storage with MinIO Client in ChatRoom.tsx NoMongo: Replace Base64 Storage with MinIO Client in ChatRoom.tsx Feb 24, 2025
@Nivedita-Chhokar
Copy link

@palisadoes Kindly assign it to me

@palisadoes
Copy link
Contributor

PTAL at the XSS and CORS vulnerabilities mentioned above that you will need to address as part of this.

@palisadoes
Copy link
Contributor

Unassigning. 2 weeks of inactivity

@palisadoes palisadoes added the good first issue Good for newcomers label Mar 9, 2025
@Akshat2gupta
Copy link

Hi @NishantSinghhhhh, I’d love to work on this issue! Since optimizing image storage with MinIO is a great improvement for performance and security, I’d be happy to implement the changes.

Could you please assign this issue to me? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

4 participants