-
-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NoMongo: Replace Base64 Storage with MinIO Client in OrgUpdate.tsx #3722
Comments
I want to work on this please @palisadoes |
PTAL at the XSS and CORS vulnerabilities mentioned above that you will need to address as part of this. |
Hi @palisadoes, Thanks |
We'll stick with our assignment policy. |
Unassigning. 2 weeks of inactivity |
Hi @NishantSinghhhhh, I’d love to work on this issue! Since optimizing image storage with MinIO is a great improvement for performance and security, I’d be happy to implement the changes. Could you please assign this issue to me? Thanks! |
Problem
OrgUpdate.tsx currently uses Base64 encoding for storing images, which increases memory usage and slows down performance.
Solution
Integrate MinIO client to upload images and store only the file URLs, reducing payload size and improving efficiency.
Alternatives Considered
Approach
Additional Context
This update will optimize image storage, enhance scalability, and improve user experience.
NOTE
We recently discovered a flaw in the code base where there are some XSS and CORS vulnerabilities. This occurs when the API and Admin servers run on different machines.
You will notice this if you configure your Admin app on your local machine to use the API running on https://test.talawa.io/graphql.
The errors in your browser will look like this:
As part of this issue you will need to ensure that the browser only interacts with the API through the Admin server and never with the API directly.
The text was updated successfully, but these errors were encountered: