You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
We take our commitment to high quality code seriously. We have test code coverage verification as part of our PR approval process.
There is a .github/workflows/eslint_disable_check.py file that is run as part of our GitHub actions that checks submitted files for statements in the code base that bypass our linting verification.
The Talawa-Admin code coverage levels are unusually high, because many contributors have used istanbul ignore statements. This does not create good code quality.
We need a script similar to the .github/workflows/eslint_disable_check.py file that is run as part of our GitHub actions.
The script must check submitted files for statements in the code base that bypass our code coverage verification.
The script must be named .github/workflows/code_coverage_disable_check.py and must have the CLI option to be run against one or more directories using the --directory like the existing lint check script
It must not check unit test files
The script must be added to our develop and develop-postgres branches
The script must be written in python3:
python black, pydocstyle, pylint, pycodestyle and flake8 linting and formatting rules applied.
It must follow the Google Python Code Style guide, especially the doc string formatting
Is your feature request related to a problem? Please describe.
.github/workflows/eslint_disable_check.py
file that is run as part of our GitHub actions that checks submitted files for statements in the code base that bypass our linting verification.istanbul ignore
statements. This does not create good code quality.Describe the solution you'd like
.github/workflows/eslint_disable_check.py
file that is run as part of our GitHub actions..github/workflows/code_coverage_disable_check.py
and must have the CLI option to be run against one or more directories using the--directory
like the existing lint check scriptdevelop
anddevelop-postgres
branchespython
black
,pydocstyle
,pylint
,pycodestyle
andflake8
linting and formatting rules applied.It must follow the Google Python Code Style guide, especially the doc string formatting
Describe alternatives you've considered
Approach to be followed (optional)
Additional context
Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship
The text was updated successfully, but these errors were encountered: