Extension bug: When asked to login on OSrPRE via extension it redirects to website

[dasaderi]

On Firefox (I have not verified this on Chrome) when using the extension to add a review directly from a preprint server the site asks to login if not yet logged. But the problem is that once orcid-mediated login happens the site brings user to the platform rather than to the form on the extension as it should do.

---

IssueHunt Summary

leonardosfl has been rewarded.

Backers (Total: $100.00)

• prereview ($100.00)

Submitted pull Requests

• #145 Fix extension bug (#138)

---

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.

[murkatr]

It does this same thing on Chrome.

[issuehunt-oss]

@prereview has funded $100.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[leonardosfl]

Hi, @dasaderi! I've implemented a fix for this. I just wanted to know if this is the right behavior.

It redirects to the login page and then returns to the previous page and opens the extension form.

Login modal:

Login button:

[dasaderi]

@leonardosfl Thank you so much! Great work!

[leonardosfl]

@dasaderi Thanks! I've submitted the PR.

[jheretic]

One more point of clarification on user interaction, @dasaderi:

@leonardosfl's #145 does fix the issue as shown. But I just wanted to mention that if there are no existing reviews or requests, it seems as if you can only login via the login link in the dropdown menu (since there's no way to summon the drawer). If you login via that link, it ultimately brings you to https://oubreaksci.prereview.org, but in a new tab. The original tab still exists and is now logged in. I think this is an acceptable workflow, I just wanted to make sure this reflects your expectations.

[leonardosfl]

it seems as if you can only login via the login link in the dropdown menu (since there's no way to summon the drawer)

It's possible to summon the drawer by pulling it from the bottom.

If you login via that link, it ultimately brings you to https://oubreaksci.prereview.org

I was not sure if I should change that link too, but it should be possible.

[leonardosfl]

Hi @dasaderi, Is this fixed?

[jheretic]

Hi @leonardosfl, I'm marking this as fixed.

[issuehunt-oss]

@murkatr has rewarded $90.00 to @leonardosfl. See it on IssueHunt

• 💰 Total deposit: $100.00
• 🎉 Repository reward(0%): $0.00
• 🔧 Service fee(10%): $10.00

[dasaderi]

@leonardosfl @jheretic I just logged in from the extension in Chrome and it did it again. After I clicked on "Log in with your Orcid", screen that showed after I tried to Add a review from medRxiv

a new window opened for the login and then I landed again in the website homepage. Has this change been deployed?

[dasaderi]

Additionally, even if I'm logged in, when I go back to the window on meRxiv, it still does not detect me as logged in.

[leonardosfl]

@dasaderi I think it has not been deployed yet

[dasaderi]

You are right, @leonardosfl. My mistake. :D We are on it!

[dasaderi]

@jheretic was this deployed?