Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new feature for method removeRow of Worksheet object which skips checks to speedup execution #4343

Open
bees4ever opened this issue Feb 6, 2025 · 1 comment

Comments

@bees4ever
Copy link

Dear Team,

first of all. Thank you for this awesome library ❤ ! I like it.

I would like to add an feature request.

As shown in the image attached I execute the removeRow method of an worksheet object, like:$worksheet->removeRow($startEmptyIndex, 12836);

As discussed in other thread, the function internally run some check before deleting a cell / row.

Image

I would like to ask if you could add another parameter which calls something like: $integrityCheck. Default value is true and on case false all these integrity checks are skipped and the remove will just run. This could speed up a deletion of a big range.

What do you think?

Regards
Ben

@oleibman
Copy link
Collaborator

Offhand, I would probably not want to provide our users a method to compromise the integrity of their spreadsheet. You refer to "other thread", but I'm not sure where to find that. Can you provide a link? Perhaps there is a persuasive argument there, but it will definitely be facing an uphill climb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants