Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate PER-CS1.0 #7281

Closed
keradus opened this issue Sep 8, 2023 · 2 comments · Fixed by #7283
Closed

Deprecate PER-CS1.0 #7281

keradus opened this issue Sep 8, 2023 · 2 comments · Fixed by #7283

Comments

@keradus
Copy link
Member

keradus commented Sep 8, 2023

after PER-CS2.0 was introduced #7249, we can deprecate PER-CS1.0

@Wirone
Copy link
Member

Wirone commented Sep 8, 2023

IMHO we should add it to the checklist in #4502 because in order to provide full PER-CS v2 we need to finish v1. When all items from the checklist are done, then we can deprecate v1. Of course, we can finish v1 ruleset while it's deprecated, but it would look weird to work on deprecated set 😅.

@keradus
Copy link
Member Author

keradus commented Sep 8, 2023

v1 and v2 are having huge overlap - v2 is basically v1 extended by new language sugar syntax possibilities.

with that, i see no harm to add the rules for v1 if it's still around, or to v2 if v1 is gone by that moment.

With that, I would love to mark v1 as deprecated to indicate users that they should start migrating to v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants