Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve cacheing of ancestry steps #239

Closed
smlmbrt opened this issue Feb 1, 2024 · 1 comment · Fixed by #244
Closed

Improve cacheing of ancestry steps #239

smlmbrt opened this issue Feb 1, 2024 · 1 comment · Fixed by #244
Labels
bug Something isn't working enhancement New feature or request

Comments

@smlmbrt
Copy link
Member

smlmbrt commented Feb 1, 2024

Description of feature

pgsc_calc seems to ignore the cached ancestry data (intersections, projections) and recalculate them when -resume is used even if the data is still in the work directory. It would be ideal if this was improved.
@smlmbrt smlmbrt added the enhancement New feature or request label Feb 1, 2024
@smlmbrt smlmbrt mentioned this issue Feb 19, 2024
Closed
@smlmbrt
Copy link
Member Author

smlmbrt commented Feb 19, 2024 •
edited
Loading

I think maybe in cache_genotypes we need to store the intersections and PCAs to make them more permanent. @nebfield thoughts?

@smlmbrt smlmbrt added the bug Something isn't working label Feb 22, 2024
@smlmbrt smlmbrt linked a pull request Feb 26, 2024 that will close this issue
v2.0.0-alpha.5 #244
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v2.0.0-alpha.5 PGScatalog/pgsc_calc
1 participant
@smlmbrt