Skip to content

petab.v1.simulate.sample_noise ignores observableTransformation #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dweindl opened this issue Apr 28, 2025 · 0 comments
Open

petab.v1.simulate.sample_noise ignores observableTransformation #382

dweindl opened this issue Apr 28, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@dweindl
Copy link
Member

dweindl commented Apr 28, 2025

petab.v1.simulate.sample_noise silently ignores observableTransformation. For example, in case of observableTransformation=log and noiseDistribution=normal, it incorrectly samples from a normal instead of a log-normal distribution.

Reported by @PaulJonasJost

@dweindl dweindl added the bug Something isn't working label Apr 28, 2025
@dweindl dweindl self-assigned this Apr 28, 2025
dweindl added a commit to dweindl/libpetab-python that referenced this issue Apr 28, 2025
Previously, `petab.v1.simulate.sample_noise` silently ignored `observableTransformation`.
For example, in case of observableTransformation=log and noiseDistribution=normal, it incorrectly sampled from a normal instead of a log-normal distribution.

Fixes PEtab-dev#382.
dweindl added a commit that referenced this issue Apr 28, 2025
…#383)

Previously, `petab.v1.simulate.sample_noise` silently ignored `observableTransformation`.
For example, in case of observableTransformation=log and noiseDistribution=normal, it incorrectly sampled from a normal instead of a log-normal distribution.

Fixes #382.

---------

Co-authored-by: Dilan Pathirana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant