Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input: Make macro chords work properly #12285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Glebux
Copy link

@Glebux Glebux commented Feb 8, 2025

Description of Changes

Macros don't trigger if you only press one key of a chord anymore, fixes #8192

InputAxisEventHandler has InputBindingKey as an argument now
InputManager::SplitChord was made public
SetMacroButtonState was changed to check if all triggers of a macro were pressed before proceeding with the input

Rationale behind Changes

To make games that utilize pressure sensitive controls, like MGS3, playable on controllers that don't have it

Suggested Testing Steps

Test this on a windows system, because I don't have one

@github-actions github-actions bot added the PAD label Feb 8, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a contribution to PCSX2

As this is your first pull request, please be aware of the contributing guidelines.

Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.

Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!

@F0bes
Copy link
Member

F0bes commented Feb 12, 2025

Can you change the commit name to have a proper prefix?
Otherwise the code looks fine to me.

@Glebux
Copy link
Author

Glebux commented Feb 12, 2025

Can you change the commit name to have a proper prefix? Otherwise the code looks fine to me.

Is this possible to reasonably accomplish using github, or I need to nuke my fork for this?

@F0bes
Copy link
Member

F0bes commented Feb 12, 2025

You want to clone your branch locally and do
git commit --amend and set the commit message again.
You'll have to git push -f afterwards. If you aren't comfortable with that, I can do it for you.

@bslenul
Copy link
Contributor

bslenul commented Feb 12, 2025

Maybe I misunderstood the PR but it doesn't seem to fix #8192 for me, as a test I set Shift+V as Circle and pressing either Shift OR V is sending a Circle input.

edit: forgot to mention but I'm on Windows 10 if it matters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Key combinations doesn't work
3 participants