[BUG] Mixed languages

[DohnJoe2]

版本号 - Version

v7.4.3

操作系统平台和系统架构 - OS and CPU Arch

Windows 10, Build 19045 x64

部署方式 - Deploy methods

• Windows .exe 安装程序 (Windows .exe Installer)
• Windows .zip 绿色部署包 (Windows .zip Portable)
• Docker
• JAR 包直接启动 (Start via .JAR directly)
• 群晖 DSM 套件 (Synology .spk package)
• Debian 软件包 (Debian .deb package)
• RedHat/Fedora 软件包 (RedHat/Fedora .rpm package)
• FreeBSD 软件包(FreeBSD .pkg package)

添加的下载器 - Added Downloaders

• qBittorrent
• BiglyBT/Azureus/Vuze
• Deluge
• Transmission
• BitComet

问题描述 - Issue Description

Started happening after updating to v7.4.0. I have both frontend and backend languages set to English but as you can see in Screenshots it displays ban reason in Chinese. Also, when changes are saved in WebUI, the popup notification is in Chinese too.

复现步骤 - Reproduce steps

I don't know how to reproduce it, did a deep reinstall but it didn't help.

截图/日志文件 - Screenshot / Logs

额外信息 - Addition Information

No response

检查清单 - Check list

• PeerBanHelper 已更新到最新版本，非最新版本不接受任何错误反馈，任何非最新版本的 Issue 将被 立 刻 关 闭，不会有人给您提供任何支持 (I'm running the latest version of PBH that can be found in Github Relases, non-latest release won't receive any support)
• 所添加的下载器已满足 README 中的前置要求（如版本号和插件）(The downloaders that I've added already satisfied the requirements (E.g install plugins/adapters))
• 我已检查过 PBH 文档（特别是常见问题），且即使使用了搜索也没有找到与此有关的内容 (This not a question/or the question that not listed in README's FAQ or PBH WIKI)
• 我没有检查这个检查清单，只是闭眼选中了所有的复选框，请关闭这个 Issue (I have not read these checkboxes and therefore I just ticked them all, Please close this issue)
• 这不是一个安全漏洞，它可以被安全的公开报告。若需要报告安全漏洞，请在此报告 (This not a security related issue, can be safe report in public. If you want report a security exploit, please report it here)
• 我同意遵守 PBH-BTN 包容性条约，不发布 “嘲讽、骂战、引战、开盒（有时也称为人肉搜索）、人身攻击、仇恨、暴力、侮辱性言辞、违法违规、黑灰产、危害国家安全、实施或帮助他人实施电信犯罪” 等内容。并已知晓如果仍旧发布了这些内容，我的账号将立刻从包括但不限于 PBH-BTN 组织、社交软件中封禁。所有主题、内容都将被立刻删除或折叠，撤销、删除和收回您所做出的一切贡献，并封禁 BTN 网络的中账号权限、排除您所提交的所有数据。在您违反相关规则时，PBH-BTN 将会将您的注册、登录、和最近访问的 IP 地址、电子邮件地址、以及其它可能追踪您或将您去匿名化的信息从定期删除转为永不删除，并在任何国家或地区的政府、公安机关或有关部门需要时无通知的提供这些数据。 (I agree to abide by the PBH-BTN Inclusivity Pact by not posting content such as “taunting, name-calling, war-mongering, open-boxing (sometimes referred to as mansplaining), personal attacks, hatred, violence, insulting language, illegal activities, black and grey business, endangering national security, and committing or assisting others in committing telecommunication crimes”. I am aware that if I continue to post such content, my account will be immediately banned from organizations including but not limited to PBH-BTN, social software. All topics and content will be immediately deleted or collapsed, all contributions will be revoked, deleted and retracted, and you will be banned from the BTN network and all data you have submitted will be excluded. In the event of a violation of these rules, PBH-BTN will delete your registration, login, and most recent IP address, email address, and any other information that may be used to track you or de-anonymize you from regular to permanent deletion, and will make this data available to the government, public security, or other relevant authorities without notice if they request it, no matter what country or region.)

[Ghost-chu]

The Chinese BanReason is part of the rule comment from the server, so it does not follow the main program language and it is not translatable.

The popup text should be a bug, it may be a fallback caused by the corresponding English translation text being missing, I will check it.

[DohnJoe2]

I don't understand from your reply if this is a bug on my end that I can fix or is it an intended feature? Because everything was in English two or three versions ago

[Ghost-chu]

I don't understand from your reply if this is a bug on my end that I can fix or is it an intended feature? Because everything was in English two or three versions ago

The reason you are seeing Chinese bans is simply because in newer versions, PeerBanHelper is able to display annotations from the server, which are obviously in Chinese. For anything other than the comments, it still follows your language. We display annotated information to improve transparency.

Older versions never displayed them.

It's a feature. Not a bug.

---

However that popup is a bug.

[Gaojianli]

I don't understand from your reply if this is a bug on my end that I can fix or is it an intended feature? Because everything was in English two or three versions ago

The reason you are seeing Chinese bans is simply because in newer versions, PeerBanHelper is able to display annotations from the server, which are obviously in Chinese. For anything other than the comments, it still follows your language. We display annotated information to improve transparency.

Older versions never displayed them.

It's a feature. Not a bug.

However that popup is a bug.

Consider provide English comment in subscribe rules

[Ghost-chu]

The language used depends on which language the person subscribing to the rules provides comments in.

PBH supports loading rule files in IP, CIDR and P2PGuard formats from any network location.
If you are using a rule from PBH-BTN, then it is obviously in Simplified Chinese.
If you are using the Swedish maintainer's rules, then it is most likely in Swedish.

I can't think of a reasonable way to introduce internationalized translations without changing the file format. And changing the file format would affect a large number of non-PeerBanHelper users (especially those who rely on the BT client's built-in IpFilter, or run some complex shell scripts).
It would be irresponsible of me to introduce destructive changes that would render it useless and cause massive outages.

We may eventually find some solutions, unfortunately right now I don't have time for that, I have to deal with a lot of tough issues in my life.
I'll keep this Issue open to deal with it in the future when I have some free time, and I'd be happy if someone submits a PR to accomplish this.

We may eventually find some solutions, unfortunately right now I don't have time for that, I have to deal with a lot of tough issues in my life.
I'll keep this Issue open to deal with it in the future when I have some free time, and I'd be happy if someone submits a PR to accomplish this.

For those wishing to contribute, there may still be the hassle of dealing with https://github.com/PBH-BTN/BTN-Collected-Rules/blob/main/tools/combine.py here.

[Gaojianli]

The language used depends on which language the person subscribing to the rules provides comments in.

PBH supports loading rule files in IP, CIDR and P2PGuard formats from any network location. If you are using a rule from PBH-BTN, then it is obviously in Simplified Chinese. If you are using the Swedish maintainer's rules, then it is most likely in Swedish.

I can't think of a reasonable way to introduce internationalized translations without changing the file format. And changing the file format would affect a large number of non-PeerBanHelper users (especially those who rely on the BT client's built-in IpFilter, or run some complex shell scripts). It would be irresponsible of me to introduce destructive changes that would render it useless and cause massive outages.

We may eventually find some solutions, unfortunately right now I don't have time for that, I have to deal with a lot of tough issues in my life. I'll keep this Issue open to deal with it in the future when I have some free time, and I'd be happy if someone submits a PR to accomplish this.

We may eventually find some solutions, unfortunately right now I don't have time for that, I have to deal with a lot of tough issues in my life. I'll keep this Issue open to deal with it in the future when I have some free time, and I'd be happy if someone submits a PR to accomplish this.

For those wishing to contribute, there may still be the hassle of dealing with https://github.com/PBH-BTN/BTN-Collected-Rules/blob/main/tools/combine.py here.

according to this screenshot,

The ban reason is a client-name based rule, which is not from network location. There's something wrong in the i18n system

[DohnJoe2]

Here's another two entries and how they differ. I don't know the internals of the PBH but my assumption would be that the backend log should reflect on the frontend UI, like it did 2-3 versions ago