-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-data M4A atoms not supported #708
Comments
not adding a |
another ponentially related issue is that this song seemingly has all the tags correct (the i should've picked a different format than m4a, but then again, youtube already has most stuff in AAC, and only some in OPUS, and i want to avoid a lossy => lossy (AAC => OPUS) transcode if possible. |
fwiw I use M4A with Auxio for multiple track artists without issue (since this issue was fixed), however I'm using generic track artist tags rather than iTunes-specific ones and also using Mp3Tag[1] for the tagging. Perhaps iTunes-specific tags aren't being parsed by Auxio/ExoPlayer? [1] Windows-only with excellent batch scripting, though for Linux I know many who use it under WINE and I've used it myself under macOS (though now there's a native, albeit non-feature-complete Mac version). |
Hey, I'll go about reproducing this later. Busy right now. |
okay, thanks! good luck with whatever you're busy with! |
Okay, so i did further investigation.
Most tools like kid3 or audio-tag-analyzer don't see any difference between a Mutagen-tagged or mp3tag tagged file (kid3 doesen't even see the multi value artist tags iirc). Here are the sample files: I tried looking at the files in the hex editor - i found that the tags were slighly different data-wise, and in a different order, however, I do not know enough about the m4a tagging spec/lack thereof and also my hex editor was pretty basic (wxhex), so it's ascii representation of the hex data wasn't great - I could not easily figure out what could be the bug in mutagens tagging that i could patch so it would work. As for the The current workaround is to just write |
Got the time to read your investigation. Very in depth, good job. I am under the impression though from my #558 implementation that Auxio should be correctly interpreting
I still won't have the time to fully confirm until later though. |
I think I know the issue with the original mp3tag file @KraXen72: It packs several data blocks into a single atom to represent multiple values. I thought M4A multi-tags were several atoms with the same identifier. ExoPlayer probably not support this right now. Mp3tag uses the format I support, several atoms with the same identifier. So yeah, this is another multi-tag format I need to support. Will get to that. |
okay, thanks a lot! i use this tagging library: https://github.com/beetbox/mediafile if you feel like the other tagging startegy is the correct one, if you want to, could you point me to where i could modify either of the libraries to tag songs correctly? i wouldn't mind using a fork of the library in my tagging script however, if it's easier/better to implement support for both strategies, go ahead with that |
Did the fix. It was pretty simple, actually. I'm fine with supporting multiple multi value conventions anyway @KraXen72. |
alright, thanks! |
Please see #708 (comment)
old message:
I am trying to tag my m4a music files with mutagen, and i've successfully added these tags:
among others. i am using https://audio-tag-analyzer.netlify.app to verify the tags.
However, in auxio, the artist only shows up as
Leah Kelly
, even if i turn on the amperstand separator.Here is my sample file:
(link removed, see later comments)
Please point me in the direction of what i should to do to fix the tagging, or try to see if it could be an auxio bug. I can see both artists, like Eden & Leah Kelly in the QuickLook windows player.
I have spent over 3 hours working on this single issue, and i had to patch the
mutagen
library to even sucessfully write the multi-value m4a tags because of a bug.Thanks!~
if of any use, this is the tagger i'm currently writing/using. see files
tagging.py
>tagger_m4a()
andmetadata.py
>get_mbids_for_song()
if interested.~The text was updated successfully, but these errors were encountered: