Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building features with class but no subtype #183

Open
jeffdefacto opened this issue Jul 17, 2024 · 5 comments
Open

Building features with class but no subtype #183

jeffdefacto opened this issue Jul 17, 2024 · 5 comments
Assignees

Comments

@jeffdefacto
Copy link

In the latest release candidate, buildings with class: bridge_structure have no subtype associated with them.

image
@atiannicelli atiannicelli self-assigned this Jul 18, 2024
@atiannicelli
Copy link

What subtype should we use?

@jeffdefacto
Copy link
Author

Its kind of an oddball one. Transportation perhaps? @LukaszMichalski-TomTom made the PR, perhaps he has an opinion.

@LukaszMichalski-TomTom
Copy link

@jeffdefacto yes that is my mistake. I added bridge_structure class but I didn't check if there is correct type for it.

@jenningsanderson
Copy link
Collaborator

Should we add a "structure" subtype or do we add this to "transportation" ? Or something else?

(7/23 buildings tf meeting)

@atiannicelli atiannicelli added this to the Release August 2024 milestone Jul 29, 2024
@atiannicelli
Copy link

I have added a subtype of "transportation" for anything with a class of bridge_structure that didn't have a subtype previously.
see the diff here

this should be fixed in August release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants