Location Encoding

Author: Outspending

.gradle/buildOutputCleanup/buildOutputCleanup.lock

@@ -0,0 +1,10 @@
+<configuration>
+    <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
+        <encoder>
+            <pattern>[%d{HH:mm:ss} %level]: %msg%n</pattern>
+        </encoder>
+    </appender>
+    <root level="debug">
+        <appender-ref ref="STDOUT" />
+    </root>
+</configuration>

build/tmp/compileJava/previous-compilation-data.bin

@@ -1,6 +1,6 @@
 package me.outspending.position;
 
-public record Location(double x, double y, double z) {
+public record Location(long x, long y, long z) {
     public static Location ZERO = new Location(0, 0, 0);
     public static Location ONE = new Location(1, 1, 1);
 }

out/production/resources/logback.xml

@@ -80,7 +80,7 @@ public void onPingRequest(@NotNull Connection client, @NotNull PingRequestPacket
     @PacketReceiver
     public void onLoginStart(@NotNull Connection client, @NotNull LoginStartPacket packet) {
         client.sendPacket(new SetCompressionPacket(-1));
-        client.sendPacket(new LoginSuccessPacket(packet.uuid(), packet.name(), new ArrayList<>()));
+        client.sendPacket(new LoginSuccessPacket(packet.uuid(), packet.name(), new LoginSuccessPacket.Property[0]));
     }
 
     @PacketReceiver
@@ -100,7 +100,7 @@ public void onAcknowledgeConfiguration(@NotNull Connection client, @NotNull Ackn
                 0,
                 false,
                 1,
-                List.of("minecraft:overworld"),
+                new String[]{"minecraft:overworld"},
                 20,
                 10,
                 8,

out/production/resources/networkCodec.nbt

@@ -117,18 +117,23 @@ public double readDouble() {
         return new UUID(readLong(), readLong());
     }
 
-    public <T> @Nullable List<T> readArray(@NotNull Function<PacketReader, T> reader, @NotNull IntFunction<T[]> generator) {
+    public <T> @Nullable T[] readArray(@NotNull Function<PacketReader, T> reader, @NotNull IntFunction<T[]> generator) {
         int length = readVarInt();
         T[] array = generator.apply(length);
         for (int i = 0; i < length; i++) {
             array[i] = reader.apply(this);
         }
 
-        return Arrays.asList(array);
+        return array;
     }
 
     public @Nullable Location readLocation() {
-        return new Location(readDouble(), readDouble(), readDouble());
+        long encoded = readLong();
+        return new Location(
+                (encoded >> 38),
+                (encoded << 52 >> 52),
+                (encoded << 26 >> 38)
+        );
     }
 
     public @Nullable CompoundBinaryTag readNBTCompound() {

src/main/java/me/outspending/position/Location.java

@@ -11,6 +11,7 @@
 
 import java.io.*;
 import java.util.UUID;
+import java.util.function.BiConsumer;
 import java.util.function.Consumer;
 
 @Getter(AccessLevel.PUBLIC)
@@ -113,7 +114,8 @@ public void writeUUID(@NotNull UUID uuid) {
         writeLong(uuid.getLeastSignificantBits());
     }
 
-    public <T> void writeArray(@NotNull Iterable<T> array, @NotNull Consumer<T> consumer) {
+    public <T> void writeArray(@NotNull T[] array, @NotNull Consumer<T> consumer) {
+        writeVarInt(array.length);
         for (T element : array) {
             consumer.accept(element);
         }
@@ -128,9 +130,7 @@ public void writePacketWriter(@NotNull PacketWriter writer) {
     }
 
     public void writeLocation(@NotNull Location location) {
-        writeDouble(location.x());
-        writeDouble(location.y());
-        writeDouble(location.z());
+        writeLong(((location.x() & 0x3FFFFFF) << 38) | ((location.z() & 0x3FFFFFF) << 12) | (location.y() & 0xFFF));
     }
 
     public void writeNBTCompound(@NotNull CompoundBinaryTag tag) {

src/main/java/me/outspending/protocol/AnnotatedPacketHandler.java

@@ -9,7 +9,7 @@
 import java.util.List;
 import java.util.UUID;
 
-public record LoginSuccessPacket(UUID uuid, String username, List<Property> properties) implements Packet {
+public record LoginSuccessPacket(UUID uuid, String username, Property[] properties) implements Packet {
     public static @NotNull LoginSuccessPacket of(@NotNull PacketReader reader) {
         return new LoginSuccessPacket(
                 reader.readUUID(),
@@ -33,7 +33,6 @@ private void writeProperty(@NotNull Property property, @NotNull PacketWriter wri
     public void write(@NotNull PacketWriter writer) {
         writer.writeUUID(uuid);
         writer.writeString(username);
-        writer.writeVarInt(properties.size());
         writer.writeArray(properties, (property) -> writeProperty(property, writer));
     }
 

src/main/java/me/outspending/protocol/PacketReader.java

@@ -14,7 +14,7 @@ public record LoginPlayPacket(
         int entityID,
         boolean isHardcore,
         int dimensionCount,
-        List<String> dimensionNames,
+        String[] dimensionNames, // Might be the issue
         int maxPlayers,
         int viewDistance,
         int simulationDistance,
@@ -30,7 +30,7 @@ public record LoginPlayPacket(
         boolean isFlatWorld,
         boolean hasDeathLocation,
         String deathDimensionName,
-        Location deathLocation,
+        Location deathLocation, // Might be the issue
         int portalCooldown
 ) implements Packet {
     public static LoginPlayPacket of(@NotNull PacketReader reader) {