Skip to content

Commit 24dc803

Browse files
committed
Pack XML documentation for public elements
Without adding the XML doc files to the nuget package, the information isn't usable in IDE tooltips or when checking class metadata and signature information, which is bad for the developer experience. This commit adds the XML docs, fixes a few malformed comments and removes warnings for missing docs on public elements and parameters.
1 parent 3738be5 commit 24dc803

File tree

4 files changed

+13
-3
lines changed

4 files changed

+13
-3
lines changed

.editorconfig

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -273,3 +273,11 @@ dotnet_naming_symbols.parameters_group.applicable_kinds = parameter
273273
dotnet_naming_rule.parameters_rule.symbols = parameters_group
274274
dotnet_naming_rule.parameters_rule.style = camel_case_style
275275
dotnet_naming_rule.parameters_rule.severity = suggestion
276+
277+
# suppress warnings about missing documentation for public elements
278+
# (hopefully one day we can turn these off)
279+
# missing on public element
280+
dotnet_diagnostic.CS1591.severity = none
281+
# missing parameter doc
282+
dotnet_diagnostic.CS1573.severity = none
283+

WebViewControl.Avalonia/WebViewControl.Avalonia.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
<Product>WebViewControl</Product>
1313
<Copyright>Copyright © 2019</Copyright>
1414
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
15+
<GenerateDocumentationFile>true</GenerateDocumentationFile>
1516
<Version>2.85.36</Version>
1617
<PackageId>WebViewControl-Avalonia</PackageId>
1718
<Authors>OutSystems</Authors>

WebViewControl/WebView.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ public partial class WebView : IDisposable {
9797

9898
public WebView() : this(false) { }
9999

100-
/// <param name="useSharedDomain">Shared domains means that the webview default domain will always be the same. When <see cref="useSharedDomain"/> is false a
100+
/// <param name="useSharedDomain">Shared domains means that the webview default domain will always be the same. When <paramref ref="useSharedDomain"/> is false a
101101
/// unique domain is used for every webview.</param>
102102
internal WebView(bool useSharedDomain) {
103103
if (IsInDesignMode) {
@@ -228,7 +228,7 @@ void InternalDispose() {
228228

229229
/// <summary>
230230
/// Specifies the maximium number of calls that can be made simultaneously to native
231-
// object methods. Defaults to the int.MaxValue.
231+
/// object methods. Defaults to the int.MaxValue.
232232
/// </summary>
233233
internal int MaxNativeMethodsParallelCalls {
234234
get => chromium.MaxNativeMethodsParallelCalls;

WebViewControl/WebViewControl.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
<Product>WebViewControl</Product>
1212
<Copyright>Copyright © 2019</Copyright>
1313
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
14+
<GenerateDocumentationFile>true</GenerateDocumentationFile>
1415
<Version>2.85.28</Version>
1516
<PackageId>WebViewControl-WPF</PackageId>
1617
<Authors>OutSystems</Authors>
@@ -51,4 +52,4 @@
5152
<PackageReference PrivateAssets="None" Include="CefGlue.Wpf" Version="85.4183.55607" />
5253
</ItemGroup>
5354

54-
</Project>
55+
</Project>

0 commit comments

Comments
 (0)