Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat - verbosity level #203

Open
JarbasAl opened this issue May 21, 2024 · 2 comments
Open

feat - verbosity level #203

JarbasAl opened this issue May 21, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@JarbasAl
Copy link
Member

JarbasAl commented May 21, 2024

i propose adding a new concept of VerbosityLevel

this would correspond to a integer from 0 - 10, added to Session

  • 0 corresponds to the default, it means a skill should speak only essential messages
  • 10 corresponds to the skill speaking a lot, ideally explaining everything it is doing along the way

a skill would check for self.verbosity_level (session aware) and conditionally speak more messages, backwards compat is retained

if self.verbosity_level > 3:
    self.speak("extra info")
if self.verbosity_level >= 9:
    self.speak("extra very redundant info")

using session allows verbosity level to be set per client (such as hivemind voice satellites), the default value would come from mycroft.conf as usual. a companion skill can also be made to control this by voice

@JarbasAl JarbasAl added the enhancement New feature or request label May 21, 2024
@JarbasAl JarbasAl self-assigned this May 21, 2024
@mike99mac
Copy link

0 corresponds to the default,
Just my two cents - I set the default to 1, and use 0 for "silent mode".

@JarbasAl
Copy link
Member Author

0 is the minimum ammount of speech, and needs to correspond to current behavior for compat reasons

if a self.speak is optional then the skill dev can require other verbosity level, we should not force 0 to mean silent, some messages might be mission critical and very important

dont want the carbon monoxide leak detector to not speak because you said "good night mycroft" right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants