Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*request* deprecated #1722

Open
Tomasz69-maker opened this issue May 20, 2020 · 1 comment
Open

*request* deprecated #1722

Tomasz69-maker opened this issue May 20, 2020 · 1 comment
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. migration Use this to indicate that it may apply to an existing or announced migration.

Comments

@Tomasz69-maker
Copy link

Note:

  • Some dep updates #1709 deprecation of request may force some async/ await usage i.e. promises. mongoose uses system promises and we have some .then, .catch syntax already.

Originally posted by @Martii in #1556 (comment)
@Martii
Copy link
Member

Martii commented May 22, 2020 •
edited
Loading

I'm also watching in my free-time, which should be more due to the world wide situation however that's not the case, nodejs/node#19393 ... so this could be a while.

UPDATE:

@Martii Martii added CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. migration Use this to indicate that it may apply to an existing or announced migration. labels May 22, 2020
@Martii Martii changed the title Note:master *request* deprecated Oct 3, 2020
@Martii Martii reopened this Oct 3, 2020
Martii added a commit to Martii/OpenUserJS.org that referenced this issue Sep 29, 2021
@Martii
Work-around for *request* issue
468c3c2 
Not entirely sure what is happening here yet. There is a 2nd http/2 request to GH to pull the favicon.ico and it results in a 400 code which might be affecting *request*.

``` console
GET https://raw.githubusercontent.com/thoughtsunificator/anime-twist-premium-extension/master/public/resource/icon192.png
[HTTP/2 304 Not Modified 41ms]

GET https://raw.githubusercontent.com/favicon.ico

GEThttps://raw.githubusercontent.com/favicon.ico
[HTTP/2 400 Bad Request 0ms]


GET
	https://raw.githubusercontent.com/favicon.ico
Status
400
Bad Request
VersionHTTP/2
Transferred20 B (20 B size)
Referrer Policystrict-origin-when-cross-origin


    HTTP/2 400 Bad Request

    content-security-policy: default-src 'none'; style-src 'unsafe-inline'; sandbox
    strict-transport-security: max-age=31536000
    x-content-type-options: nosniff
    x-frame-options: deny
    x-xss-protection: 1; mode=block
    content-type: text/plain; charset=utf-8
    x-github-request-id: BFCA:398E:20EA4:2B1D1:6154C049
    accept-ranges: bytes
    date: Wed, 29 Sep 2021 19:36:41 GMT
    via: 1.1 varnish
    x-served-by: *clipped*
    x-cache: MISS
    x-cache-hits: 0
    x-timer: S1632944201.991904,VS0,VE55
    vary: Authorization,Accept-Encoding,Origin
    access-control-allow-origin: *
    x-fastly-request-id: 6430a82547959939007b65990d31d046decc784d
    expires: Wed, 29 Sep 2021 19:41:41 GMT
    content-length: 20
    X-Firefox-Spdy: h2
    Accept
    	image/webp,*/*
    Accept-Encoding
    	gzip, deflate, br
    Accept-Language
    	en-US,en;q=0.5
    Connection
    	keep-alive
    DNT
    	1
    Host
    	raw.githubusercontent.com
    Referer
    	https://raw.githubusercontent.com/thoughtsunificator/anime-twist-premium-extension/master/public/resource/icon192.png
    Sec-Fetch-Dest
    	image
    Sec-Fetch-Mode
    	no-cors
    Sec-Fetch-Site
    	same-origin
    Sec-GPC
    	1
    User-Agent
    	Mozilla/5.0 (X11; Linux x86_64; rv:92.0) Gecko/20100101 Firefox/92.0
```

See also:
* https://openuserjs.org/discuss/Changing_my_linked_git_hub_account#comment-17c32e96846
* OpenUserJS#1722
@Martii Martii mentioned this issue Sep 29, 2021
Merged
Martii added a commit that referenced this issue Sep 29, 2021
@Martii
Work-around for *request* issue (#1839)
7a2f3d6 
Not entirely sure what is happening here yet. There is a 2nd http/2 request to GH to pull the favicon.ico and it results in a 400 code which might be affecting *request*.

``` console
GET https://raw.githubusercontent.com/thoughtsunificator/anime-twist-premium-extension/master/public/resource/icon192.png
[HTTP/2 304 Not Modified 41ms]

GET https://raw.githubusercontent.com/favicon.ico

GEThttps://raw.githubusercontent.com/favicon.ico
[HTTP/2 400 Bad Request 0ms]


GET
	https://raw.githubusercontent.com/favicon.ico
Status
400
Bad Request
VersionHTTP/2
Transferred20 B (20 B size)
Referrer Policystrict-origin-when-cross-origin


    HTTP/2 400 Bad Request

    content-security-policy: default-src 'none'; style-src 'unsafe-inline'; sandbox
    strict-transport-security: max-age=31536000
    x-content-type-options: nosniff
    x-frame-options: deny
    x-xss-protection: 1; mode=block
    content-type: text/plain; charset=utf-8
    x-github-request-id: BFCA:398E:20EA4:2B1D1:6154C049
    accept-ranges: bytes
    date: Wed, 29 Sep 2021 19:36:41 GMT
    via: 1.1 varnish
    x-served-by: *clipped*
    x-cache: MISS
    x-cache-hits: 0
    x-timer: S1632944201.991904,VS0,VE55
    vary: Authorization,Accept-Encoding,Origin
    access-control-allow-origin: *
    x-fastly-request-id: 6430a82547959939007b65990d31d046decc784d
    expires: Wed, 29 Sep 2021 19:41:41 GMT
    content-length: 20
    X-Firefox-Spdy: h2
    Accept
    	image/webp,*/*
    Accept-Encoding
    	gzip, deflate, br
    Accept-Language
    	en-US,en;q=0.5
    Connection
    	keep-alive
    DNT
    	1
    Host
    	raw.githubusercontent.com
    Referer
    	https://raw.githubusercontent.com/thoughtsunificator/anime-twist-premium-extension/master/public/resource/icon192.png
    Sec-Fetch-Dest
    	image
    Sec-Fetch-Mode
    	no-cors
    Sec-Fetch-Site
    	same-origin
    Sec-GPC
    	1
    User-Agent
    	Mozilla/5.0 (X11; Linux x86_64; rv:92.0) Gecko/20100101 Firefox/92.0
```

See also:
* https://openuserjs.org/discuss/Changing_my_linked_git_hub_account#comment-17c32e96846
* #1722

Auto-merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. migration Use this to indicate that it may apply to an existing or announced migration.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Martii @Tomasz69-maker