Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch for possible breaking change in GM4 regarding invalid @match patterns. #1330

Open
Martii opened this issue Feb 12, 2018 · 1 comment
Open

Watch for possible breaking change in GM4 regarding invalid @match patterns. #1330

Martii opened this issue Feb 12, 2018 · 1 comment
Labels
needs mitigation Needs additional followup. tracking upstream Waiting, watching, wanting.

Comments

@Martii
Copy link
Member

Martii commented Feb 12, 2018

Most existing .user.js engines should abort installation altogether. If they don't then it will make it too wide and match on every site. I assume that Greasyfork may have an issue with their detections as well if this change in behavior comes to fruition.

Btw current Chrome and Chromium native .user.js parsing (e.g. no Tampermonkey) comes back with an error message of:

Chromium native .user.js parsing of bad match pattern

Cc: @Sxderp, @JasonBarnabe

Ref(s):
@Martii Martii added tracking upstream Waiting, watching, wanting. needs mitigation Needs additional followup. labels Feb 12, 2018
@Martii
Copy link
Member Author

Martii commented Mar 21, 2019

Btw this has been busted (changed) in GM4 e.g. they skip over it now from greasemonkey/greasemonkey@0c4ad19

@Martii Martii mentioned this issue Mar 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs mitigation Needs additional followup. tracking upstream Waiting, watching, wanting.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Martii