Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdopteUnMec custom filtering #88

Open
Amustache opened this issue Apr 26, 2022 · 3 comments
Open

AdopteUnMec custom filtering #88

Amustache opened this issue Apr 26, 2022 · 3 comments

Comments

@Amustache
Copy link
Contributor

Re: #63, after looking into the code, I noticed that the whole document is availble in cgvuDatas["cookiesDatas"]["data"] within a js script. Is it possible ti select that way or not?

@MattiSG
Copy link
Member

MattiSG commented Apr 28, 2022

If I understand correctly, not at the moment. But please have a look at OpenTermsArchive/engine#745, and if it matches your situation, add this document as an example! 🙂

@Amustache
Copy link
Contributor Author

It's not exactly JSON, but it can be parsed as such... But yes, the situation is quite the same.

Should I reference it anyway?

@MattiSG
Copy link
Member

MattiSG commented May 9, 2022

Aah sorry, I had not understood. I then assume that cgvuDatas is a JS object. If it is populated through an XHR (in which case there is an underlying JSON resource), then yes, please reference it!
If it is loaded as part of a JS script, then I don't think it is relevant to use it as a source: unless the HTML document is especially hard to parse, the fragility brought by parsing code variables seems too risky for Open Terms Archive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants