Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Tests on _file_to_saveload.abstract_ftype in afterload do the wrong thing when joining as network client #12681

Closed
JGRennison opened this issue May 14, 2024 · 0 comments

Comments

@JGRennison
Copy link
Contributor

Version of OpenTTD

master

Expected result

Scenario setup code guarded by _file_to_saveload.abstract_ftype == FT_SCENARIO should only run when actually loading a scenario.

Actual result

If a scenario is loaded, and then a network game is joined, _file_to_saveload.abstract_ftype is still set to FT_SCENARIO.

Company inauguration years are reset in the client but not the server. However, these are not used for anything important so should not cause a desync.

Steps to reproduce

See above

JGRennison added a commit to JGRennison/Upstream-OpenTTD that referenced this issue May 19, 2024
@PeterN PeterN closed this as completed in 42fc322 May 22, 2024
@PeterN PeterN added backport requested This PR should be backport to current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants