Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Database missing/inconsistent fields #12

Open
jigglepuff opened this issue Aug 9, 2019 · 2 comments
Open

Fix Database missing/inconsistent fields #12

jigglepuff opened this issue Aug 9, 2019 · 2 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@jigglepuff
Copy link
Contributor

  • Price fields (VB, NC, SL) is mostly not populated: may need to look into/rework automation.
  • Check if some varchar fields can be generated as int or bool (e.g. num stories, basement_finished etc.)

Full list of attributes being utilized as of 08/09/2019:
"_parcel_id"
"acres"
"attic"
"basement_finished"
"basement_type"
"bath_full"
"bath_half"
"bath_total"
"bldg_type"
"central_heat"
"com_grd_flr"
"construction"
"garage"
"lot_type"
"nbrhd_code"
"nbrhd_name"
"num_stories"
"price_bldg"
"price_lot"
"price_residential"
"price_sidelot"
"size_sqFt"
"wall_material"
"ward_num"
"zip"

@dacresni dacresni added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed documentation Improvements or additions to documentation and removed good first issue Good for newcomers labels Oct 24, 2019
@acady14
Copy link

acady14 commented Oct 30, 2019

I've dug up my old (and very ugly) code and can definitely update the price list/actually push the code this time and maybe add a comment or two.

Big question while I'm working on that though: right now this is a one-time offline update of parcel prices. It makes more sense long term to integrate this into whatever database update process we have going. Is there such a process in the repo now, and if so, where is it?

@acady14
Copy link

acady14 commented Oct 30, 2019

Related--do we also want to change the field names to something more descriptive? We decided on those names last time at the behest of some of the city folks...but we certainly don't have to stick with them. I could get on board with something like price_VacantBuilding, price_NewConstruction, price_SideLot, etc...but I'll leave it up to the backend folks to let me know what they want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants