Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attendance Module & API Improvements. #625

Closed
dasunhegoda opened this issue Oct 11, 2024 · 3 comments · Fixed by #616
Closed

Attendance Module & API Improvements. #625

dasunhegoda opened this issue Oct 11, 2024 · 3 comments · Fixed by #616
Assignees

Comments

@dasunhegoda
Copy link
Contributor

dasunhegoda commented Oct 11, 2024

The proposed improvements as follows

attendance_type & attendance_location

  • The attendance_type & attendance_location fields should be an integer value.
  • The values for attendance_type & attendance_location should be fetched dynamically from an API when it's used.
  • The attendance_type & attendance_location dropdown should be populated with these fetched values, and user input should be restricted to prevent manual typing to avoid errors.
  • We need to determine if attendance_location should be a sub-type of attendance_type based on specific use cases.

submitted_by

  • Update the submitted_by field to store the user_id or another parameter to identify the user submitting the attendance.
  • Add a new parameter submission_source to identify which application is being used to submit the attendance, such as self-reg, OCR, etc.

Timestamp for submission_date

  • The submitted_date field should be stored as a timestamp with hours, minutes, and seconds for better precision.

Data audit logging in attendance module

  • All values retrieved from the attendance server for program management purposes within the SP-MIS must be stored in the attendance module to ensure traceability.

Options for retrieving data from the attendance server (Optional)

  • Option 1: When new data becomes available on the attendance server, a webhook will automatically trigger and push the relevant data to the SP-MIS in real-time.
  • Option 2: Configure the SP-MIS to periodically poll the attendance server and pull any new or updated data at regular intervals.
  • Should the data pushed from the attendance server to SP-MIS be archived upon receipt? If so, what is the retention period for storing this data
  • We need to decide which approach we should take here
@reichie020212 reichie020212 linked a pull request Nov 19, 2024 that will close this issue
@reichie020212
Copy link
Member

reichie020212 commented Nov 19, 2024

All of the necessary details are already included in this PR #616. The only missing part is the last section that needs further discussion.

@celinenilla
Copy link

@dasunhegoda has confirmed that all implemented parts fulfill his requests. For the last missing part we will discuss it in a meeting to agree on the path forward. Keeping ticket "In review" while waiting for the meeting

@celinenilla
Copy link

The remaining issue has been created as its own ticket in #713 . This ticket can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants