Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CVE, CVSS, CVRF Features #2108

Merged
merged 7 commits into from
Jun 4, 2024
Merged

Remove CVE, CVSS, CVRF Features #2108

merged 7 commits into from
Jun 4, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented May 15, 2024

This PR removes CVE, CVSS, and CVRF features.

This is in one PR as the three features are closely related and it was easier to just remove them all at once.

Fixes #2087
Fixes #2088
Fixes #2089

@Mab879 Mab879 added this to the 1.4 milestone May 15, 2024
@Mab879 Mab879 marked this pull request as ready for review May 28, 2024 20:26
Copy link
Member

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

schemas/cvrf/1.1/cvrf_1.1.xsd Show resolved Hide resolved
@@ -675,8 +675,7 @@ int oscap_source_validate_schematron_priv(struct oscap_source *source, oscap_doc
scap_type == OSCAP_DOCUMENT_CPE_DICTIONARY ||
scap_type == OSCAP_DOCUMENT_CVE_FEED ||
scap_type == OSCAP_DOCUMENT_SCE_RESULT ||
scap_type == OSCAP_DOCUMENT_OCIL ||
scap_type == OSCAP_DOCUMENT_CVRF_FEED) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove remaining occurrences of OSCAP_DOCUMENT_CVRF_FEED from other files in src as well.

schemas/cve/nvd-cve-feed_2.0.xsd Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Member

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great removal of obsolete features!

The CI fail on Fedora Latest isn't caused by this PR and will be fixed in #2118.

I have built and run oscap, reviewed the CLI and I have read the man page.

@jan-cerny
Copy link
Member

At this moment, it isn't possible to build and run tests on CentOS Stream 8 because CentOS Stream 8 has been sunset.

@jan-cerny jan-cerny merged commit 484d46c into OpenSCAP:main Jun 4, 2024
13 of 16 checks passed
@Mab879 Mab879 deleted the drop_cvss branch June 4, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop oscap cvrf feature Drop oscap cvss feature Drop oscap cve feature
2 participants