The method ApplyClientBehavior inside IEndpointBehavior gets not call after updating openria to 5.3.1

[neplan]

Describe the bug
After updating from 4.6 to 5.3.1 the authentication is not working anymore. We have found out thath our SharedCookieHttpBehavior is not working as we expected. The ApplyClientBehavior seems not to be called:

public class SharedCookieHttpBehavior : IEndpointBehavior
    {
        private static readonly CookieContainer Container = new CookieContainer();
        public void AddBindingParameters(ServiceEndpoint endpoint, BindingParameterCollection bindingParameters)
        {
        }
        public void ApplyClientBehavior(ServiceEndpoint endpoint, ClientRuntime clientRuntime)
        {
            clientRuntime.ClientMessageInspectors.Add(new SharedCookieMessageInspector(Container));
        }
        public void ApplyDispatchBehavior(ServiceEndpoint endpoint, EndpointDispatcher endpointDispatcher)
        {
        }
        public void Validate(ServiceEndpoint endpoint)
        {
        }
        public static string GetCookies(string url)
        {
            string cookie = null;
            if(Container != null)
            {
                var uri = new Uri(url);
                cookie = Container.GetCookieHeader(uri);
            }
            return cookie;
        }
        public static void SetCookieContainer(HttpCookie cookie, Uri uri)
        {
            if (string.IsNullOrWhiteSpace(cookie.Domain))                
                cookie.Domain = uri.Host;
            var header = $"{cookie.Name}={cookie.Value}";
            Container.SetCookies(uri, header);
        }
        public static CookieContainer GetCookieContainer()
        {
            return Container;
        }
    }

We are adding this Endpointbehavior in the EndpointBehavior of the channel:

 public static class DomainContextExtensions
    {
        public static void ShareCookieContainer(this DomainContext domainContext)
        {
            // Try to get the channel factory property from the domain client 
            // of the domain context. In case that this property does not exist
            // we throw an invalid operation exception.
            var channelFactoryProperty = domainContext.DomainClient.GetType().GetProperty("ChannelFactory");
            if (channelFactoryProperty == null)
            {
                throw new InvalidOperationException("The 'ChannelFactory' property on the DomainClient does not exist.");
            }

            // Now get the channel factory from the domain client and set the
            // new timeout to the binding of the service endpoint.
            var factory = (ChannelFactory)channelFactoryProperty.GetValue(domainContext.DomainClient, null);
            var httpBinding = ((CustomBinding)factory.Endpoint.Binding).Elements.Find<HttpTransportBindingElement>();
            if (httpBinding != null)
            {
                httpBinding.AllowCookies = true;
            }

            var httpsBinding = ((CustomBinding)factory.Endpoint.Binding).Elements.Find<HttpsTransportBindingElement>();
            if (httpsBinding != null)
            {
                httpsBinding.AllowCookies = true;
            }
            factory.Endpoint.EndpointBehaviors.Add(new SharedCookieHttpBehavior());
        }
    }

Are we missing something?

[SandstromErik]

Hi @neplan, I will have a look at this when I have time, probably in the next couple of days and hopefully find a solution

[neplan]

Hi @SandstromErik . This would be great. Thank you.

[SandstromErik]

I found that the ChannelFactory is opened when retrieving it in the extension method, which means that adding additional EndPointBehaviors will not initialize them, i.e. ApplyClientBehaviour will not be called for the additional behaviour.
I am investigating if ChannelFactory needs to be opened or if that code can be removed.

[neplan]

Ok. Thank you. Am 05.07.2023 17:28, schrieb Erik Sandström:

…

I found that the `ChannelFactory` is opened when retrieving it in the extension method, which means that adding additional `EndPointBehaviors` will not initialize them, i.e. `ApplyClientBehaviour` will not be called for the additional behaviour. I am investigating if `ChannelFactory` needs to be opened or if that code can be removed.

[Daniel-Svensson]

If you need to add your custom behaviour you need to write your own DomainClientFactory, se #267 (comment) for a similar issue and proposed solution.

Some other notes:

• If you want to extend the communication pipeline you are better of switching to use the BinaryHttpDomainClientFactory introduced in 5.1.0 which uses HttpClient and HttpClientHandler so you can write DelegatingHandlers to extend the request pipeline as you wich and can add existing libraries for Oauth , retries etc.
• Support for cookies is built in (unless you need to modify them), just set the CookieContainer on the WebDomainClientFactory and it will set AllowCookies to true for you