Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected text doesn’t always persist when highlighting #10

Open
jhdouglas opened this issue Dec 9, 2016 · 2 comments
Open

Selected text doesn’t always persist when highlighting #10

jhdouglas opened this issue Dec 9, 2016 · 2 comments

Comments

@jhdouglas
Copy link
Collaborator

jhdouglas commented Dec 9, 2016

Users have the ability to select/deselect portions of the transcript by highlighting text. Currently, however, selecting text and clicking outside of the highlight doesn’t always persist. It appears that users must click completely outside of the transcript for the selection to remain, which isn’t immediately apparent.

  1. Open autoEdit 2 app
  2. Add file to have access to transcript
  3. Open transcript show page
  4. In highlight mode, begin selecting text
  5. Observe text is highlighted
  6. Click to remove highlight
  7. Note selection does not persist

highlight_persist

@pietrop
Copy link
Collaborator

pietrop commented Dec 9, 2016

Making a note to look into the selection library rangy as possible solution when refactoring this.

@pietrop
Copy link
Collaborator

pietrop commented Apr 26, 2017

This only happens if selecting and then click along side the selection.
There is possibly something to do with which element is associated with the user selection listener.

@pietrop pietrop added the ready label Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants