Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal Glasses #71

Open
TechnicianLP opened this issue Jul 26, 2015 · 9 comments
Open

Terminal Glasses #71

TechnicianLP opened this issue Jul 26, 2015 · 9 comments

Comments

@TechnicianLP
Copy link

It would be nice if the glasses could be crafted together with any helmet and still remains its functinality
(maybe adding a custom nbt tag to the helmet for tracking glasses) or something like an enchantment

@Selim042
Copy link

I don't know exactly what you want to put them on, but I have a mod called 'Omni-Things', might work for your purposes.

@TechnicianLP
Copy link
Author

Not exactly what i wanted i wanted an option to add the Glass-GUI to any helmet so i dont have to give up protection or a set Bonus but still have the option to display anything on screen
after having a brief look over the code it should not be too hard to do it via a NBT-Tag

@natedogith1
Copy link

I'd like to see this too. I also wanted to mention that bilbiocraft does something like this (using an enchantment) for its reading glasses. I'd prefer an NBT tag though, as some armor doesn't like enchantments (and you'd probably need an NBT tag anyways to store the bridge id)

@boq
Copy link
Member

boq commented Jul 30, 2015

This was already suggested few times, but there are few things that block me from implementing it:

  • No mechanism for signalling changes in armor slots (though there are few Forge PR, though not yet merged). Without it I have no other way to register new terminals other than scanning every player every tick, which is ugly
  • Storage. If I keep that in custom NBT structure, there is no guarantee it will stay there - it depends on other mod. Enchantments are usually semi-safe, but I don't like the idea of adding technical functionality via "magic"

@TechnicianLP
Copy link
Author

But you don't have to scan for the glasses? ....

@boq
Copy link
Member

boq commented Jul 30, 2015

OP needs to send current state of glasses exact moment player puts it on. Also, there is this event for new user.

@natedogith1
Copy link

Could you have the glasses also be a bauble?

@TechnicianLP
Copy link
Author

if i could like comments you would get one ...

@nevercast
Copy link
Member

Somewhat duplicate: #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants