Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove launcher code from stacktrace #3

Open
Johni0702 opened this issue Jul 18, 2019 · 0 comments
Open

Remove launcher code from stacktrace #3

Johni0702 opened this issue Jul 18, 2019 · 0 comments

Comments

@Johni0702
Copy link

MultiMC launches MC from its own wrapper class for reasons leading to duplicate crash reports:
https://openeye.openmods.info/crashes/ccfdcc458cd87da5d75d51493f740403
https://openeye.openmods.info/crashes/1901be9a40fe69ba7ca917288b83edf9
There appear to be other launchers doing similar stuff, e.g. https://openeye.openmods.info/crashes/8f1faca0ffefb8e6a79c0742bea7a108

Everything further down the stack than net.minecraft.launchwrapper.Launch.main(Launch.java:28) can probably just be dropped without much issues.

For some reason the reflection between launchwrapper and nmcm.Main doesn't have any source file nor line. No idea why.
Instead one could also cut at net.minecraft.client.main.Main.main() which would solve that issue but then one would loose the info that it's using launchwrapper as opposed to modlauncher (Forge 1.13+) or knot (Fabric).
But then again, 99% of crashes will probably not depend on the specific launcher used, so personally I'm for cutting at nmcm.Main.

Beware that the source name and line may change over different versions but package/class/method should always be the same (at least for 1.6.4-1.14.3).
Servers do not appear to be affected from this issue (though tbh I'm not entirely why).
Also remember that on the uppermost stacktrace should be modified and not any of the caused by (yes, that's a server so it wouldn't be affected anyway but it was the first one with caused-by that I could find).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant