Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation suggestion: StrobeSpeed + ShutterStrobe #3981

Open
kengruven opened this issue May 20, 2024 · 0 comments
Open

Validation suggestion: StrobeSpeed + ShutterStrobe #3981

kengruven opened this issue May 20, 2024 · 0 comments

Comments

@kengruven
Copy link
Contributor

There are many fixtures (and proposed fixtures) which are written with capabilities like this:

        {
          "dmxRange": [128, 250],
          "type": "StrobeSpeed",
          "speedStart": "1Hz",
          "speedEnd": "20Hz"
        },
        {
          "dmxRange": [251, 255],
          "type": "ShutterStrobe",
          "shutterEffect": "Open"
        }

which is almost certainly wrong: StrobeSpeed is a global setting, not an enabler of the strobe feature, so a sibling capability of type ShutterStrobe is indicative that this isn't what was intended.

In the above case, it should be:

        {
          "dmxRange": [128, 250],
          "type": "ShutterStrobe",
          "shutterEffect": "Strobe",
          "speedStart": "1Hz",
          "speedEnd": "20Hz"
        },
        {
          "dmxRange": [251, 255],
          "type": "ShutterStrobe",
          "shutterEffect": "Open"
        }

It would be great if we could catch this mistake earlier (in the editor, or the validator) so we didn't end up with a bunch of these to fix in review, or which accidentally pass review and end up in OFL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant