-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Fine tuning" doings #432
Comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
There are a couple of things that could be improved.
Instead of creating for every small change a issue, keep track of theme here.
unref()
all "keep alive"/"broken connection detection" timers + cronDATABASE_UPDATE_DEBOUNCE_TIMER
, context: https://stackoverflow.com/q/77847416/5781499 ¹npm run test
runs forever/do not exit #435 (comment) ¹unref
npm run test
child processBIN_PATH_TAR=/usr/lib/tar
,BIN_PATH_NPM=/usr/bin/npm
or/usr/bin/env npm
//usr/bin/env tar
TODO
/NOTE
comments!
, e.g.!class.commands.js
fields
property fromclass.logger.js
: https://github.com/OpenHausIO/backend/blob/d17066bd3bd43878371d2fa618651068c95ed78c/system/logger/class.logger.js#L50?plain=1HTTP_ADDRESS
toHTTP_HOST
²ISSUES.md
&NOTES.md
logger.warn(err, "foo bar")
and notlogger.warn("foo bar", err)
constants.js
: MongoDB ID/MAC regex, Symbols, Components name array, etc.npm run test
#370 (comment))¹) Needs further investigation if it breaks something or so...
²) Breaking change!
The text was updated successfully, but these errors were encountered: