You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This will fail, but note that it'll fail to call localhost:9999
It's basically using the wrong endpoint value
Specific issues here:
I should be able to pass all arguments into the CLI directly, not use config.json
Any args I explicitly pass must be used. For example if I do, openfn deploy --api-key $MY_OPENFN_PAT, that key must be used above what's in the env and config
If an arg isn't explicitly provided, we should look in config
Finally, if no other arg is set, we should try and read from the env.
It's super useful too, in debug logging, to track which arguments were read from where. Values can be useful too, but be careful of API keys (maybe log first 6 chars)
Note that we use --pat elsewhere in the CLI to pass an api key. idk which is better right now but we should be consistent. Or alias consistently.
The text was updated successfully, but these errors were encountered:
I've been tracking this in my head for ages. I have big plans for CLI deploy which will likely subsume this. But I wanted to get this logged because it's not a big fix and is probably worth doing
A really really big problem in CLI deploy is that argument precedence is totally wrong.
Usually, the closest argument to the command is the one that wins. But this isn't true. And it's really annoying.
To repro (no need to set anything up remotely):
OPENFN_ENDPOINT
tohttps://localhost:9999
(or any port where nothing is running)openfn deploy pull -c config.json
Specific issues here:
openfn deploy --api-key $MY_OPENFN_PAT
, that key must be used above what's in the env and configIt's super useful too, in debug logging, to track which arguments were read from where. Values can be useful too, but be careful of API keys (maybe log first 6 chars)
Note that we use
--pat
elsewhere in the CLI to pass an api key. idk which is better right now but we should be consistent. Or alias consistently.The text was updated successfully, but these errors were encountered: