-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node 20: mock-fs breaks #834
Comments
Notes on the problem form @doc-han 👍
Our only failing tests are in packages/cli/test/commands.test.ts |
I think we need to look for a different solution to commands.test.ts. The options as I see it right now:
|
When updating to node 20,
mock-fs
breaks.We use mock-fs extensively in unit tests to load fake adaptor files and such. Bumping the mock-fs version helps, but we also have a problem dynamically importing modues.
Basically mock-fs will only mock the filesystem for
node:fs
. When usingimport()
(as we do in the runtime to load adaptors), the file system isn't mocked out at all.The text was updated successfully, but these errors were encountered: