Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CF spec: make OMB reader CF-friendly #78

Open
jerabaul29 opened this issue Aug 7, 2023 · 7 comments
Open

CF spec: make OMB reader CF-friendly #78

jerabaul29 opened this issue Aug 7, 2023 · 7 comments
Labels

Comments

@jerabaul29
Copy link
Collaborator

At the moment, the OMB reader is not really CF-friendly. I should update it. I will likely wait until there is more OMB development happening and I can harmonize everything. WIP list of things to update:

@gauteh
Copy link
Member

gauteh commented Jun 12, 2024

Here's all the correct standard names: https://github.com/gauteh/sfy/blob/main/sfy-processing/sfy/xr.py#L129 , we are using this function a lot lately for different projects.

@mikapm

@knutfrode
Copy link
Contributor

What you here call long_name is actually standard_name:
https://cfconventions.org/Data/cf-conventions/cf-conventions-1.11/cf-conventions.html#long-name

So standard_name is the unique identifier (e.g. sea_surface_wave_significant_height), whereas long_name is ad hoc and to be used e.g. for labeling axes (e.g. Significant wave height, Hauteur de vague importante or Merkittävä aallonkorkeus).

@gauteh
Copy link
Member

gauteh commented Jun 12, 2024

Doh! That should be fixed!

@mikapm
Copy link

mikapm commented Jun 12, 2024 via email

@gauteh
Copy link
Member

gauteh commented Jun 12, 2024 via email

@knutfrode
Copy link
Contributor

@mikapm
Copy link

mikapm commented Jun 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants