Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOF plots: no colors in the legend #1276

Open
Yuri05 opened this issue Sep 6, 2024 · 5 comments
Open

GOF plots: no colors in the legend #1276

Yuri05 opened this issue Sep 6, 2024 · 5 comments

Comments

@Yuri05
Copy link
Member

Yuri05 commented Sep 6, 2024

E.g. check this plot (RE 2.2.363):
https://github.com/Yuri05/TestReport/blob/main/Test_Verapamil/report.md#figure-3-1
Different symbols are properly displayed in the legend, but colours are ignored (all symbols in the legend are black)

@pchelle
Copy link
Collaborator

pchelle commented Sep 9, 2024

In the configuration plan,
Symbols and legend captions are associated with Groups displayed in the legend captions.
But colors can be associated with the output mappings within each group.
Thus, multiple colors are possible for one symbol

@pchelle
Copy link
Collaborator

pchelle commented Sep 9, 2024

Different solutions are possible here.

  • Do not show the color in the legend (currently done)
  • Show the first color from each Output Mapping in the legend
  • Show the color in the legend only if there is only one color for the Output Mapping, and show black otherwise

@Yuri05
Copy link
Member Author

Yuri05 commented Sep 9, 2024

In the configuration plan, Symbols and legend captions are associated with Groups displayed in the legend captions. But colors can be associated with the output mappings within each group. Thus, multiple colors are possible for one symbol

hmm, indeed. I just wonder why we define the colour then on the output mapping level and not on the group level.
@pchelle Do you remember the reason?

OK, let's keep it AS IS for now.

@pchelle
Copy link
Collaborator

pchelle commented Sep 9, 2024

I don't remember why.
The last example I have checked had different mappings due to different observed data sets, but used the same simulation.
Since now we can group the observed data sets together, may be the output mapping can be simplified.

@Yuri05
Copy link
Member Author

Yuri05 commented Sep 24, 2024

to discuss with @TWendl

@Yuri05 Yuri05 added this to the 2.3: Qualification workflow milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants