Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending Issues when 12.1 Core merges into develop branch #1799

Open
benjaperez1983 opened this issue Feb 5, 2025 · 0 comments
Open

Pending Issues when 12.1 Core merges into develop branch #1799

benjaperez1983 opened this issue Feb 5, 2025 · 0 comments
Assignees

Comments

@benjaperez1983
Copy link
Contributor

On PK-Sim add this call:
Class: ImportObservedDataTask
Method: AddAndReplaceObservedDataFromConfigurationToProject

public void AddAndReplaceObservedDataFromConfigurationToProject(ImporterConfiguration configuration, IEnumerable observedDataFromSameFile)
{
var importedObservedData = getObservedDataFromImporter(configuration, null, false, false);
var reloadDataSets = _dataImporter.CalculateReloadDataSetsFromConfiguration(importedObservedData.ToList(), observedDataFromSameFile.ToList());

if (reloadDataSets == null) return;

foreach (var dataSet in reloadDataSets.NewDataSets)
{
   adjustMolWeight(dataSet);
   _observedDataTask.AddObservedDataToProject(dataSet);
   updateQuantityInfoInImportedColumns(dataSet);
}

foreach (var dataSet in reloadDataSets.DataSetsToBeDeleted.ToArray()) //toDo it should be checked if to array solves the deleting problem
{
   _observedDataTask.Delete(dataSet);
}

foreach (var dataSet in reloadDataSets.OverwrittenDataSets)
{
   //TODO this here should be tested
   var existingDataSet = findDataRepositoryInList(observedDataFromSameFile, dataSet);

   foreach (var column in dataSet.Columns)
   {
      var datacolumn = new DataColumn(column.Id, column.Name, column.Dimension, column.BaseGrid)
      {
         QuantityInfo = column.QuantityInfo,
         DataInfo = column.DataInfo,
         IsInternal = column.IsInternal,
         Values = column.Values
      };

      if (column.IsBaseGrid())
      {
         existingDataSet.BaseGrid.Values = datacolumn.Values;
      }
      else
      {
         var existingColumn = existingDataSet.FirstOrDefault(x => x.Name == column.Name);
         if (existingColumn == null)
            existingDataSet.Add(column);
         else
            existingColumn.Values = column.Values;
      }
   }
   
}
_parameterIdentificationTask.UpdateParameterIdentificationsUsing(observedDataFromSameFile);
foreach (var dataset in observedDataFromSameFile)
{
   _eventPublisher.PublishEvent(new ObservedDataValueChangedEvent(dataset));
}

}

on MOBI:
Class: ObservedDataTask
Method: AddAndReplaceObservedDataFromConfigurationToProject:
_parameterIdentificationTask.UpdateParameterIdentificationsUsing(observedDataFromSameFile);

@benjaperez1983 benjaperez1983 self-assigned this Feb 5, 2025
@benjaperez1983 benjaperez1983 moved this to Todo in v12.1 Feb 5, 2025
@rwmcintosh rwmcintosh changed the title Pending Issues when 12.1 Core merges into master branch Pending Issues when 12.1 Core merges into develop branch Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant