Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is not possible to overwrite a parameter that is defined in AllCalculationMethods.pkml #1740

Open
PavelBal opened this issue Jan 8, 2025 · 0 comments

Comments

@PavelBal
Copy link
Member

PavelBal commented Jan 8, 2025

OverwriteBlackBoxParameter.zip

Short version

In the attached project, there are four modules:

1. OriginalBrain: a minimal spatial structure with the "Brain" organ and the corresponding neighborhoods
2. OriginalBrain_overrideParam: same as 1, but the parameter Partition coefficient (interstitial/water) is overwritten by a constant
3. RenamePlasma: same as 1. but the container Plasma has been renamed.
4. RenamePlasma_overrideParam: as 3., but the parameter Partition coefficient (interstitial/water) is overwritten

Parameter OriginalBrain|Neighborhoods|Brain_int_Brain_cell|TestMolecule|Partition coefficient (interstitial/water) is a help parameter defined in AllCalculationMethods.pkml

      <HelpParameters>
        <KeyValue>
          <Parameter id="K-w01rtMKUGrdBV4WF2-Yg" name="Partition coefficient (interstitial/water)" icon="Parameter" persistable="0" isFixedValue="0" quantityType="Parameter" negativeValuesAllowed="1" formula="Interstitial partition coefficient method - Schmitt.PARAM_K_water_int_Schmitt" isDefault="1">
            <Info min="0" flag="52" seq="1" ref="0" bb="2" group="117" />
          </Parameter>
          <DescriptorCriteria operator="And">
            <DescriptorConditions>
              <MatchTagCondition tag="Neighborhood: Interstitial / Intracellular" />
            </DescriptorConditions>
          </DescriptorCriteria>
        </KeyValue>
      </HelpParameters>

When creating a simulation, the parameter is automatically added:

image

I try to overwrite this parameter by manually creating it in the neighborhood and setting it to a constant value (the use case would be when altering the structure, e.g., renaming or fully removing the Plasma container):

image

In the simulation that uses this module, the parameter again uses the black box formula and not the value defined by the user:

image

The expected behavior would be that the help parameter is only added when it is not present in the original structure.

@PavelBal PavelBal added this to v13 Jan 8, 2025
@github-project-automation github-project-automation bot moved this to Under discussion (technically feasible; open for sponsorship) in OSP Suite Software Roadmap Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Under discussion (technically feasible; open for sponsorship)
Status: No status
Development

No branches or pull requests

1 participant