Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison of results #132

Open
Yuri05 opened this issue Apr 27, 2018 · 9 comments
Open

Comparison of results #132

Yuri05 opened this issue Apr 27, 2018 · 9 comments

Comments

@Yuri05
Copy link
Member

Yuri05 commented Apr 27, 2018

If 7.2.2-installation validator is started on a system, where 7.2.1-validator run was performed (using the same output folder), validation fails, because in 7.2.2 some obsolete simulations were removed.

Obviously Installation Validator uses users Output folder as "master", which is wrong.
It should use the installed output folder as master

aufnahme35

@msevestre
Copy link
Member

This is not the issue. The tool always compare files in both folders. Since calculation were already performed , some previous files are in the folder already

The tool should empty the output folder before running the comparison. Don't you think that this is the problem?

@msevestre
Copy link
Member

@Yuri05 There is no master. Missing simulations are shown from both folders. This could be changed but the concept of master folder is not there

@msevestre
Copy link
Member

Which also shows that one should not remove stuff between two update release

@Yuri05
Copy link
Member Author

Yuri05 commented Apr 27, 2018

Missing simulations are shown from both folders. This could be changed but the concept of master folder is not there

If missing sims are shown for both folders it would be sufficient to delete all json files from the output folder.

@UlrichSi
Copy link
Member

Cleaning up behind program execution sounds like a good idea. Our local (SSD) drives fill up pretty quickly anyhow.

@Yuri05
Copy link
Member Author

Yuri05 commented Apr 27, 2018

Cleaning up behind program execution sounds like a good idea. Our local (SSD) drives fill up pretty quickly anyhow.

We might need the outputs for investigation in case of failures

@UlrichSi
Copy link
Member

True - maybe instead cleaning up the output of previous runs when a new validation run is started?

@Yuri05
Copy link
Member Author

Yuri05 commented Apr 27, 2018

True - maybe instead cleaning up the output of previous runs when a new validation run is started?

In my opinion this should not happen automatically. We could introduce a button "Delete results from previous validations" or something like that. If the user never changed a default output folder, those can be located and cleaned up. (But I am not fan of this)

@msevestre
Copy link
Member

So what should we do here? The error only happens bercause we did not respect semantic versioning and removed stuff in a minor release. In my opinion there is nothing to change

@Yuri05 Yuri05 removed the type: bug label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants