Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto create account with SSO, email ? #5118

Open
devildant opened this issue May 19, 2024 · 4 comments
Open

auto create account with SSO, email ? #5118

devildant opened this issue May 19, 2024 · 4 comments

Comments

@devildant
Copy link

devildant commented May 19, 2024

Summary

Hello,
I use the Enable authentication option with header variable, it works perfectly with my sso.
but I don't know where to put the email header:
X-Forwarded-Email
my user is created using the "X-Forwarded-user" header, but the user is created without email

Ombi Version

4.43.5

What platform(s) does this occur on?

Docker

What database are you using?

SQLite (Default)

Relevant log output

No response

@devildant
Copy link
Author

it's maybe a feature request ?

@tidusjar
Copy link
Member

tidusjar commented Jun 6, 2024

Yeah sort of. But should be simple to add

@shwetd19
Copy link

Hey there 👋,

It's a practical issue that could streamline the user creation process with SSO.

Since users are currently created without an email due to the absence of this header, finding the right place to incorporate it is key.

A potential fix could involve modifying the authentication handler to explicitly look for the X-Forwarded-Email header alongside the X-Forwarded-User header. This might involve adjusting the middleware or the user creation logic to ensure the email is captured and stored correctly.

Would it be possible to let me tackle this?

Cheers,
@shwetd19

@tidusjar
Copy link
Member

Yes 100% happy for you to take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants