Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing to/from csv truncates joint names #12

Open
DavidLSmyth opened this issue Sep 2, 2020 · 2 comments
Open

Writing to/from csv truncates joint names #12

DavidLSmyth opened this issue Sep 2, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@DavidLSmyth
Copy link

DavidLSmyth commented Sep 2, 2020

data = np.array(data, dtype=[('joint', np.unicode_, 20),

('parent', np.unicode_, 20),

limits the length of the joint names to 20, but in tests, you have joint names which are much longer, creating artifacts in the csvs such as:

mixamorig:LeftHandMi,mixamorig:LeftHandMi, 3.60930, -0.16690, 0.07780
mixamorig:LeftHandMi,mixamorig:LeftHandMi, 3.40040, -0.62740, 0.11480
mixamorig:LeftHandMi,mixamorig:LeftHandMi, 3.62050, -0.64930, 0.11990

Maybe adding an invertibility test (bvh -> csv -> bvh) would be of value? This could be part of #11

@OlafHaag OlafHaag added the bug Something isn't working label Sep 2, 2020
@OlafHaag
Copy link
Owner

OlafHaag commented Sep 2, 2020

Thanks for reporting the issue! I'm not sure why I did limit it to 20 characters. I guess, it's a relic from the data I originally developed this module for. If you need a fix asap I could just raise the limit to 120 or whatever, otherwise I plan to revisit this whole package at the end of this year. There's a lot I would like to refactor and as you mentioned, adding tests.

@DavidLSmyth
Copy link
Author

No worries, as others have pointed out in other issues, the csv to bvh feature is a handy one as more datasets are being released which contain pose data as csvs instead of bvh or other formats. No need for an immediate fix on my end, thought better to flag for anyone else using. Thanks for the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants