Skip to content

Write unit tests for all the existing rules #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xiaoyunyang opened this issue Jan 10, 2022 · 1 comment
Open

Write unit tests for all the existing rules #11

xiaoyunyang opened this issue Jan 10, 2022 · 1 comment
Labels
good first issue Good for newcomers

Comments

@xiaoyunyang
Copy link
Contributor

Scope of the work:

  1. Add jest
  2. Write unit tests for the existing rules

The most complex rule to write unit tests for is prefer-smartquote as there are many edge cases. Here are some cases to consider:
actual final BEFORE
t-tagged BEFORE
@xiaoyunyang xiaoyunyang added the good first issue Good for newcomers label Jan 10, 2022
@S0han
Copy link

S0han commented Jan 11, 2022

i would like to assist....i am more junior level though
ive used jest briefly before any tips/pointers are to how to tackle this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xiaoyunyang @S0han