Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export more functionality from p2p package #3043

Open
KaloyanTanev opened this issue Apr 19, 2024 · 0 comments
Open

Export more functionality from p2p package #3043

KaloyanTanev opened this issue Apr 19, 2024 · 0 comments
Labels
protocol Protocol Team tickets

Comments

@KaloyanTanev
Copy link
Contributor

🎯 Problem to be solved

Currently the p2p package has a lot of useful functionality that can be used in testing command, unit tests or any other packages. Functions like pingPeerOnce could be exported and reused. Consider adding setupP2P function, similar to what is used in dkg and cmd packages.

🛠️ Proposed solution

Export functionalities that seem suitable to be used outside of p2p package. Refactor arguments and outputs wherever required, to make it more general.

🧪 Tests

Existing test cases should be passing.

👐 Additional acceptance criteria

Remove the copied functionality in other packages and replace it with the new exported functions.

@github-actions github-actions bot added the protocol Protocol Team tickets label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Protocol Team tickets
Projects
None yet
Development

No branches or pull requests

1 participant