Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration timestamp before genesis causes fatal crash in Charon #3007

Open
3 tasks
boulder225 opened this issue Mar 30, 2024 · 0 comments
Open
3 tasks

Registration timestamp before genesis causes fatal crash in Charon #3007

boulder225 opened this issue Mar 30, 2024 · 0 comments
Labels
bug Something isn't working protocol Protocol Team tickets

Comments

@boulder225
Copy link
Collaborator

🎯 Problem to be solved

Charon crashes when splitting keys with v0.19.2 and running the cluster with the new lock and keys, but this does not happen with v0.19.0.

set": "stable", "feature-set-disable": "[]", "feature-set-enable": "[]", "help": "false", "jaeger-address": "", "jaeger-service": "node0", "lock-file": "/opt/charon/.charon/cluster/node0/cluster-lock.json", "log-color": "auto", "log-format": "console", "log-level": "debug", "log-output-path": "", "loki-addresses": "[]", "loki-service": "charon", "manifest-file": ".charon/cluster-manifest.pb", "monitoring-address": "0.0.0.0:3620", "no-verify": "false", "p2p-disable-reuseport": "false", "p2p-external-hostname": "node0", "p2p-external-ip": "", "p2p-relays": "[https://0.relay.obol.tech]", "p2p-tcp-address": "[0.0.0.0:3610]", "private-key-file": "/opt/charon/.charon/cluster/node0/charon-enr-private-key", "private-key-file-lock": "false", "simnet-beacon-mock": "false", "simnet-beacon-mock-fuzz": "false", "simnet-slot-duration": "1s", "simnet-validator-keys-dir": ".charon/validator_keys", "simnet-validator-mock": "false", "synthetic-block-proposals": "false", "testnet-chain-id": "3151908", "testnet-fork-version": "0x10000038", "testnet-genesis-timestamp": "1711629991", "testnet-name": "testnet", "validator-api-address": "0.0.0.0:3600"}
2024-03-28 18:16:36 12:46:36.866 INFO app-start  Charon starting                          {"version": "v0.19.2", "git_commit_hash": "53e044c", "git_commit_time": "2024-03-05T13:37:23Z"}
2024-03-28 18:16:37 12:46:37.745 INFO app-start  Resolved new relay                       {"peer": "dazzling-mirror", "url": "https://0.relay.obol.tech", "addrs": "[/ip4/34.141.223.64/tcp/3610]"}
2024-03-28 18:16:38 12:46:38.020 INFO app-start  Lock file loaded                         {"peer_name": "misty-ring", "peer_index": 0, "cluster_hash": "6c8c1ec", "cluster_name": "test", "peers": 3}
2024-03-28 18:16:38 12:46:38.027 ERRO cmd        Fatal error: wire recaster: calculate slot from timestamp: registration timestamp before genesis
2024-03-28 18:16:38     app/app.go:1052 .slotFromTimestamp
2024-03-28 18:16:38     app/app.go:633 .newRecaster
2024-03-28 18:16:38     app/app.go:489 .wireCoreWorkflow
2024-03-28 18:16:38     app/app.go:266 .Run
2024-03-28 18:16:38     cmd/run.go:37 .func1
2024-03-28 18:16:38     cmd/cmd.go:80 .func1
2024-03-28 18:16:38     main.go:19 .main

This is probably related to #2810 since the genesis timestamp must be greater or equal to the timestamp at which splitting the keys. This happened because it was a genesis testnet and won't happen in kurtosis tests.

🛠️ Proposed solution

  • Relax the check that fails when registration timestamp is before genesis
  • Instead of fatal crash, log a warning and continue
  • Consider allowing registration timestamp to be before genesis in certain cases
@boulder225 boulder225 added the bug Something isn't working label Mar 30, 2024
@github-actions github-actions bot added the protocol Protocol Team tickets label Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working protocol Protocol Team tickets
Projects
None yet
Development

No branches or pull requests

1 participant