Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use branch name as the ÖbEngine version if the branch name uses the format "dev-v\d+(\.\d+){,2}" #399

Open
Sygmei opened this issue Oct 16, 2021 · 0 comments
Assignees
Labels
enhancement The issue should enhance an existing feature good first issue Issue that is easy to work on if you don't know the engine hacktoberfest For Hacktoberfest help wanted Help wanted on the issue
Projects

Comments

@Sygmei
Copy link
Member

Sygmei commented Oct 16, 2021

v1
v2
v1.2
v0.5
v0.5.6

are all valid patterns

Right now, to inject version into ÖbEngine, it uses the last tag, so if you checkout to an older tag / branch, the version will not be correct.

This issue requires two things :

  • if the current branch is named dev-vX / dev-vX.Y / dev-vX.Y.Z, use that version number (vX will become vX.0.0, vX.Y will become X.Y.0)
  • if the branch is not using the dev-vX.Y.Z pattern, find out if one of the parent branch uses this pattern or use closest defined tag

Here are a few examples :

...
[tag v0.3.0]
|
master
|
[tag v0.4.0]
|
new_branch <= You are here

> Version : 0.4.0
...
[tag v0.3.0]
|
master
|
[tag v0.4.4]
|
v0.5
|
new_branch <= You are here

> Version : 0.5.0
...
[tag v0.3.0]
|
master
|
[tag v0.4.4]
|
v0.5
|
[tag v0.4.9] # I know it does not make sense, just to illustrate
|
new_branch <= You are here
|
[tag v0.6.0]

> Version : 0.4.9

Current implementation can be found here

@Sygmei Sygmei added enhancement The issue should enhance an existing feature help wanted Help wanted on the issue hacktoberfest For Hacktoberfest good first issue Issue that is easy to work on if you don't know the engine labels Oct 16, 2021
@Sygmei Sygmei added this to To do in Version 0.5 via automation Oct 16, 2021
@Sygmei Sygmei removed this from To do in Version 0.5 Jun 20, 2022
@Sygmei Sygmei added this to To do in Version 0.6 via automation Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue should enhance an existing feature good first issue Issue that is easy to work on if you don't know the engine hacktoberfest For Hacktoberfest help wanted Help wanted on the issue
Projects
Version 0.6
  
To do
Development

No branches or pull requests

2 participants