Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSS Reorganization #591

Open
ThunderSon opened this issue Oct 20, 2020 · 18 comments · May be fixed by #1074
Open

XSS Reorganization #591

ThunderSon opened this issue Oct 20, 2020 · 18 comments · May be fixed by #1074
Assignees
Labels
enhancement A new or improved feature for the WSTG or repo
Milestone

Comments

@ThunderSon
Copy link
Collaborator

What's the current setup?
Reviewing XSS overall in the document, it's split into 2 different chapters, 7 and 11.
At the end of the day, all XSS will target users on the client-side, even if it was stored.

What would you like to happen?
Move all XSS to chapter 11, client-side testing, and have one big section for XSS and then going into more tests for other types of testing.
What do you guys think?

@ThunderSon ThunderSon added the enhancement A new or improved feature for the WSTG or repo label Oct 20, 2020
@kingthorin kingthorin added this to the v4.3 Release milestone Nov 10, 2020
@github-actions

This comment has been minimized.

@Magii204
Copy link
Contributor

I would like to be work on this.

Magii204 added a commit to Magii204/wstg that referenced this issue Jan 22, 2021
This was referenced Jan 22, 2021
Magii204 added a commit to Magii204/wstg that referenced this issue Jan 26, 2021
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

Please comment if you are still working on this issue, as it has been inactive for 90 days. To give everyone a chance to contribute, we are releasing it to new contributors.

@linzinha
Copy link

I can do this, since they still seem to be in separate chapters.

@linzinha
Copy link

Hows this for order? Unless you just wanted 7 added to the end of chapter 11

01-Testing_for_Reflected_Cross_Site_Scripting.md
02-Testing_for_Stored_Cross_Site_Scripting.md
03-Testing_for_HTTP_Verb_Tampering.md
04-Testing_for_HTTP_Parameter_Pollution.md
15-Testing_for_HTTP_Splitting_Smuggling.md
16-Testing_for_HTTP_Incoming_Requests.md
08-Testing_for_SSI_Injection.md
12-Testing_for_Command_Injection.md
13-Testing_for_Buffer_Overflow.md
13-Testing_for_Format_String_Injection.md
14-Testing_for_Incubated_Vulnerability.md
18-Testing_for_Server-side_Template_Injection.md
19-Testing_for_Server-Side_Request_Forgery.md
10-Testing_for_IMAP_SMTP_Injection.md
07-Testing_for_XML_Injection.md
09-Testing_for_XPath_Injection.md
05-Testing_for_SQL_Injection.md
05.1-Testing_for_Oracle.md
05.2-Testing_for_MySQL.md
05.3-Testing_for_SQL_Server.md
05.4-Testing_PostgreSQL.md
05.5-Testing_for_MS_Access.md
05.6-Testing_for_NoSQL_Injection.md
05.7-Testing_for_ORM_Injection.md
05.8-Testing_for_Client-side.md
11-Testing_for_Code_Injection.md
11.1-Testing_for_File_Inclusion.md
02-Testing_for_JavaScript_Execution.md
03-Testing_for_HTML_Injection.md
05-Testing_for_CSS_Injection.md
08-Testing_for_Cross_Site_Flashing.md
09-Testing_for_Clickjacking.md
10-Testing_WebSockets.md
11-Testing_Web_Messaging.md
12-Testing_Browser_Storage.md
13-Testing_for_Cross_Site_Script_Inclusion.md
04-Testing_for_Client-side_URL_Redirect.md
06-Testing_for_Client-side_Resource_Manipulation.md
01-Testing_for_DOM-based_Cross_Site_Scripting.md
01.1-Testing_for_Self_DOM_Based_Cross_Site_Scripting.md
07-Testing_Cross_Origin_Resource_Sharing.md
17-Testing_for_Host_Header_Injection.md
06-Testing_for_LDAP_Injection.md

@kingthorin
Copy link
Collaborator

kingthorin commented Oct 16, 2021

No no, to be clear XSS is the only thing that's moving.

Any XSS scenarios that are currently in section 7 should move to section 11.

01-Testing_for_Reflected_Cross_Site_Scripting.md
02-Testing_for_Stored_Cross_Site_Scripting.md

Should move into a unified XSS section with DOM in 11. Something like:

01-Testing_for_Reflected_Cross_Site_Scripting.md
02-Testing_for_Stored_Cross_Site_Scripting.md
03-Testing_for_DOM-based_Cross_Site_Scripting.md
03.1-Testing_for_Self_DOM_Based_Cross_Site_Scripting.md

or

01 Testing for Cross Site Scripting
01.1-Testing_for_Reflected_Cross_Site_Scripting.md
01.2-Testing_for_Stored_Cross_Site_Scripting.md
01.3-Testing_for_DOM-based_Cross_Site_Scripting.md
01.4-Testing_for_Self_DOM_Based_Cross_Site_Scripting.md

Something along those lines. Have a look at it, have a look at how SQLi is done since this could be similar.

@kingthorin
Copy link
Collaborator

^ edited: had further thoughts 😉

@linzinha
Copy link

Ok great, thanks for the clarification! I'm double-checking section 7 now

@linzinha
Copy link

I deleted my last comment, was looking at the wrong tab!

@kingthorin
Copy link
Collaborator

Those are already in 11 👍

@linzinha
Copy link

Yeah, there was a sudden bit of chaos in the house and I realized with the distraction I'd been looking at 11 not 7

@kingthorin
Copy link
Collaborator

All good, been there.

@manindar-mohan manindar-mohan linked a pull request Jun 30, 2023 that will close this issue
2 tasks
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jun 30, 2023
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jun 30, 2023
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jun 30, 2023
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jun 30, 2023
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jun 30, 2023
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jun 30, 2023
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jun 30, 2023
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jun 30, 2023
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jun 30, 2023
…Testing/12-Testing_for_Format_String_Injection (OWASP#591)
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jun 30, 2023
…Testing/13-Testing_for_Incubated_Vulnerability (OWASP#591)
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jun 30, 2023
…Testing/14-Testing_for_HTTP_Splitting_Smuggling (OWASP#591)
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jun 30, 2023
…alidation_Testing/16-Testing_for_Host_Header_Injection (OWASP#591)
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jun 30, 2023
…lidation_Testing/17-Testing_for_Server-side_Template_Injection (OWASP#591)
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jun 30, 2023
…lidation_Testing/18-Testing_for_Server-Side_Request_Forgery (OWASP#591)
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jun 30, 2023
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jun 30, 2023
…ng/01.1-Testing_for_Reflected_Cross_Site_Scripting (OWASP#591)
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jun 30, 2023
…ng/01.2-Testing_for_Stored_Cross_Site_Scripting (OWASP#591)
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jun 30, 2023
…ng/01.4-Testing_for_Self_DOM_Based_Cross_Site_Scripting (OWASP#591)
@kingthorin kingthorin modified the milestones: v4.3 Release, v5.0 Release Jun 30, 2023
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jul 1, 2023
…07-Input_Validation_Testing/03-Testing_for_SQL_Injection (OWASP#591)
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jul 1, 2023
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jul 1, 2023
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jul 1, 2023
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jul 1, 2023
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jul 1, 2023
manindar-mohan pushed a commit to manindar-mohan/wstg that referenced this issue Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new or improved feature for the WSTG or repo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants