Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Risk - Cryptographic Keys Not Properly Protected at Rest [crypto-keys-not-protected-at-rest] #2578

Open
4 tasks
cpholguera opened this issue Mar 1, 2024 · 0 comments

Comments

@cpholguera
Copy link
Collaborator

Description

Create a new risk for "Cryptographic Keys Not Properly Protected at Rest (MASVS-CRYPTO-2)" using the following information:

e.g. storing keys in SharedPreferences, storing keys in files, hardcoded keys, etc.

Create "risks/MASVS-CRYPTO/2-***-****/crypto-keys-not-protected-at-rest/risk.md" including the following content:

---
title: Cryptographic Keys Not Properly Protected at Rest
alias: crypto-keys-not-protected-at-rest
platform: [android, ios]
profiles: [L1, L2]
mappings:
  masvs-v1: [MSTG-STORAGE-1]
  masvs-v2: [MASVS-CRYPTO-2, MASVS-STORAGE-1]
  mastg-v1: [MASTG-TEST-0052, MASTG-TEST-0001]

---

## Overview

## Impact

## Modes of Introduction

## Mitigations

To complete the sections follow the guidelines from Writing MASTG Risks & Tests

Use at least the following references:

When creating the corresponding tests, use the following areas to guide you:

  • platform keystore (Android KeyStore / iOS KeyChain)
  • TEE/SE
  • Cryptographic Keys Not Encrypted with key from platform keystore. envelope encryption (DEK+KEK) (considered "equivalent protection")
  • Key Wrapping (NIST.SP.800-175Br1 5.3.5)

MASTG v1 Refactoring:

If the risk has a MASVS v1 ID, you can use it to search for related tests in the MASTG and use them as input to define your risks and associated tests.

Acceptance Criteria

  • The risk has been created in the correct directory (risks/MASVS-CRYPTO/2-***-****/crypto-keys-not-protected-at-rest/risk.md)
  • The risk content follows the guidelines
  • At least one GitHub Issue has been created for the corresponding tests (derived from "Modes of Introduction")
  • The risk indicates the related MASTG v1 tests in its metadata.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant