Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Broken link in MASVS-RESILIENCE/MASTG-TEST-0050.md #2569

Closed
chagemann opened this issue Feb 24, 2024 · 9 comments · Fixed by #2616
Closed

[Bug] Broken link in MASVS-RESILIENCE/MASTG-TEST-0050.md #2569

chagemann opened this issue Feb 24, 2024 · 9 comments · Fixed by #2616
Assignees
Labels

Comments

@chagemann
Copy link
Collaborator

chagemann commented Feb 24, 2024

MASTG Chapter

MASVS-RESILIENCE/MASTG-TEST-0050

File Line Number

21

Context

link to Tampering and Reverse Engineering on Android returns 404


The link points to ../../../Document/0x05c-Reverse-Engineering-and-Tampering.md which was removed in #2439:

Removed chapters 0x05c and 0x05c (content split into individual techniques for the Techniques section and merged to 0x05b and 0x06b for the PDF)

I also noticed 0x04c-Tampering-and-Reverse-Engineering.md which seems to be a better fit than 0x05b.

A full text search of 0x05c-Reverse-Engineering-and-Tampering.md reveals 37 matches in 25 files.

Happy to submit a PR if you could give me guidance on the replacement link.

@cpholguera
Copy link
Collaborator

Hi @chagemann, thanks for reporting this and sorry for the delay in responding. I've investigated the issue further and we have the same situation with the corresponding iOS chapter.

Thanks for volunteering to fix the problem! To make things easier for you, I've started the fixes here. You can continue the work on the fix-broken-links-to-5c-6c branch (if you cannot push to that branch, just let me know).

I used vscode to search for all links:

image

See this example in the screenshot:

> This repackaging method is enough for most use cases. For more advanced repackaging, refer to
 ["Android Tampering and Reverse Engineering - Patching, Repackaging and Re-Signing"](0x05c-Reverse-Engineering-and-Tampering.md#patching-repackaging-and-re-signing).

You can use the title "Patching, Repackaging and Re-Signing" or the anchor "#patching-repackaging-and-re-signing" to search for the right technique in https://mas.owasp.org/MASTG/techniques/

In this case, among the Android techniques you can find: "MASTG-TECH-0039: Repackaging & Re-Signing"

image

So the fixed text would be:

> This repackaging method is enough for most use cases. For more advanced repackaging, refer to
 ["Repackaging & Re-Signing"](../../techniques/android/MASTG-TECH-0039.md "Repackaging & Re-Signing")

@cpholguera
Copy link
Collaborator

Hi @chagemann, will you be able to continue the work here: #2607? Should I assign it to you? Thanks!

@chagemann
Copy link
Collaborator Author

chagemann commented May 5, 2024

@cpholguera Yes, please assign it to me.

And please grant me permission to push to this branch.

@cpholguera
Copy link
Collaborator

@chagemann I've invited you to the project. Once you accept I'll assign it to you. Thanks so much!

@chagemann
Copy link
Collaborator Author

@cpholguera Thank you - invite accepted.

@cpholguera
Copy link
Collaborator

Thanks! It's assigned to you now ✅

@chagemann
Copy link
Collaborator Author

@cpholguera Could you please check my permissions:

> owasp-mastg git:(fix-broken-links-to-5c-6c) git status
On branch fix-broken-links-to-5c-6c
Your branch is ahead of 'origin/fix-broken-links-to-5c-6c' by 1 commit.
  (use "git push" to publish your local commits)

nothing to commit, working tree clean
> owasp-mastg git:(fix-broken-links-to-5c-6c) git push
ERROR: Permission to OWASP/owasp-mastg.git denied to chagemann.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@cpholguera
Copy link
Collaborator

cpholguera commented May 11, 2024

@chagemann I'm going to merge my PR and you can open another PR for the same ticket and continue the work there. That's gonna be easier. Thanks for letting me know!

@cpholguera
Copy link
Collaborator

It's merged now. You can work on a branch in your fork and open a PR against our master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants