Skip to content

Reverting a PR - Github Enterprise responds with a 500 when changes include a regex match #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ambernormand opened this issue Sep 10, 2020 · 2 comments

Comments

@ambernormand
Copy link

A team was attempting to revert a PR via the github UI. Within the PR there was a removal of 2 lines that matched regexes (in this case they happened to be test secrets). When the team attempted the revert in the PR they get an error page with Github Enterprise responding with a 500 response. The error didn't provide any feedback from the SEDATED script but upon reaching out to Github Support we were able to retrieve the SEDATED feedback to see what was happening.

The failure reason makes sense, code that includes a regex match is attempting to be added back to the source code. But the team didn't receive any helpful information to resolve the issue.

Has anyone else run into this? Is there an expected workaround in this case?

@sclouts
Copy link
Collaborator

sclouts commented Sep 29, 2020

@ambernormand In this scenario, the user "should" see the SEDATED output with the reference to those 2 lines of code. But, being you saw a 500 response I'm thinking this might occur if SEDATED faces a 5 second timeout. Did you attempt this multiple times?

@ambernormand
Copy link
Author

It's been a while since we've run into this since reverting PRs isn't super common but I tested again a few times and can confirm I see a failure that GHE provides a 500 & it wouldn't be a case where the 5 second timeout is occurring.

This could be a setting in our GE potentially? but we do see other SEDATED feedback via the UI as expected. I'm wondering if anyone else can reproduce - if not then I can just close this and we can work to handle this issue internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants