Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: Refactor default_values #183

Open
willu47 opened this issue Jun 21, 2023 · 0 comments
Open

[FEATURE]: Refactor default_values #183

willu47 opened this issue Jun 21, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@willu47
Copy link
Member

willu47 commented Jun 21, 2023

Feature Request

There is no reason to "read in" default values in the ReadStrategy subclasses as this information is now stored in config.

Is your feature related to a bug?

No response

Suggested Solution

This functionality can be removed, and the ReadStrategy.read() method can return just the data rather than the tuple of data and default values.

The WriteStrategy does require default values if the write_defaults flag is set to True. So we can move the get_defauylts method over to the write strategies.

Additional Info

No response
@willu47 willu47 added the enhancement New feature or request label Jun 21, 2023
@trevorb1 trevorb1 mentioned this issue Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@willu47