-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can I remove the CPL_CVSID macro? #11433
Comments
Looking at https://codesearch.debian.net/search?q=CPL_CVSID and confirming with https://github.com/search?q=repo%3AOSGeo%2Fgdal-grass%20CPL_CVSID&type=code, OSGeo/gdal-grass is a known user of the macro (hopefully the only one... ?) . So a preliminary step would be to remove its use from there, wait for an official release of OSGeo/gdal-grass, and then remove it here |
This macro dates back to CVS time and would only make sense if we substituted the $Id$, which we don't do. We also plan to remove the macro from GDAL's cpl_port.h header in OSGeo/gdal#11433 , so let's remove use of it by its only known external user :-)
gdal-grass pull request removing their use of CPL_CVSID: OSGeo/gdal-grass#50 |
This macro dates back to CVS time and would only make sense if we substituted the $Id$, which we don't do. We also plan to remove the macro from GDAL's cpl_port.h header in OSGeo/gdal#11433 , so let's remove use of it by its only known external user :-)
Feature description
Any objections to me removing the
CPL_CVSID()
macro? It's no longer present in any source files? Are there any uses of GDAL that count on CPL_CVSID being present?Happy to make a PR, but want to check first.
Additional context
No response
The text was updated successfully, but these errors were encountered: